MDL-80866 phpunit: Fix failures after disabling Chat and Survey

admin/presets/tests/helper_test.php

@@ -344,7 +344,7 @@ public function change_default_preset_provider(): array {
                 ],
                 'plugins' => [
                     'assign' => 1,
-                    'chat' => 1,
+                    'book' => 1,
                     'data' => 1,
                     'lesson' => 1,
                 ],

blocks/recentlyaccesseditems/tests/externallib_test.php

@@ -58,7 +58,7 @@ public function test_get_recent_items() {
             $generator->enrol_user($student->id, $course->id, 'student');
             $forum[] = $this->getDataGenerator()->create_module('forum', array('course' => $course));
             $glossary[] = $this->getDataGenerator()->create_module('glossary', array('course' => $course));
-            $chat[] = $this->getDataGenerator()->create_module('chat', array('course' => $course));
+            $assign[] = $this->getDataGenerator()->create_module('assign', ['course' => $course]);
         }
         $generator->enrol_user($teacher->id, $courses[0]->id, 'teacher');
 
@@ -81,7 +81,7 @@ public function test_get_recent_items() {
         $this->assertCount(count($forum), $result);
 
         // Student access all assignments.
-        foreach ($chat as $module) {
+        foreach ($assign as $module) {
             $event = \mod_chat\event\course_module_viewed::create(array('context' => \context_module::instance($module->cmid),
                     'objectid' => $module->id));
             $event->trigger();
@@ -90,7 +90,7 @@ public function test_get_recent_items() {
 
         // Test that results are sorted by timeaccess DESC (default).
         $result = \block_recentlyaccesseditems\external::get_recent_items();
-        $this->assertCount((count($forum) + count($chat)), $result);
+        $this->assertCount((count($forum) + count($assign)), $result);
         foreach ($result as $key => $record) {
             if ($key == 0) {
                 continue;
@@ -101,11 +101,11 @@ public function test_get_recent_items() {
         // Delete a course and confirm it's activities don't get returned.
         delete_course($courses[0], false);
         $result = \block_recentlyaccesseditems\external::get_recent_items();
-        $this->assertCount((count($forum) + count($chat)) - 2, $result);
+        $this->assertCount((count($forum) + count($assign)) - 2, $result);
 
         // Delete a single course module should still return.
         course_delete_module($forum[1]->cmid);
         $result = \block_recentlyaccesseditems\external::get_recent_items();
-        $this->assertCount((count($forum) + count($chat)) - 3, $result);
+        $this->assertCount((count($forum) + count($assign)) - 3, $result);
     }
 }

completion/tests/bulk_update_test.php

@@ -158,6 +158,11 @@ public function test_bulk_form_submit_single($modname, $submitdata, $validatedat
     protected function create_course_and_modules($modulenames) {
         global $CFG, $PAGE;
 
+        // Chat and Survey modules are disabled by default, enable them for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
+        $manager::enable_plugin('survey', 1);
+
         $CFG->enablecompletion = true;
         $course = $this->getDataGenerator()->create_course(['enablecompletion' => 1], ['createsections' => true]);
         $PAGE->set_course($course);

course/tests/externallib_test.php

@@ -3189,8 +3189,24 @@ public function test_check_updates() {
 
         // Create different types of activities.
         $course  = self::getDataGenerator()->create_course();
-        $tocreate = array('assign', 'book', 'choice', 'folder', 'forum', 'glossary', 'imscp', 'label', 'lti', 'page', 'quiz',
-                            'resource', 'scorm', 'survey', 'url', 'wiki');
+        $tocreate = [
+            'assign',
+            'book',
+            'choice',
+            'folder',
+            'forum',
+            'glossary',
+            'imscp',
+            'label',
+            'lesson',
+            'lti',
+            'page',
+            'quiz',
+            'resource',
+            'scorm',
+            'url',
+            'wiki',
+        ];
 
         $modules = array();
         foreach ($tocreate as $modname) {

lib/phpunit/classes/restore_date_testcase.php

@@ -115,6 +115,15 @@ protected function backup_and_restore($course, $newdate = 0) {
      * @return array
      */
     protected function create_course_and_module($modulename, $record = []) {
+        if ($modulename == 'chat') {
+            $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+            $manager::enable_plugin('chat', 1);
+        }
+        if ($modulename == 'survey') {
+            $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+            $manager::enable_plugin('survey', 1);
+        }
+
         // Create a course with specific start date.
         $record = (array)$record;
         $generator = $this->getDataGenerator();

lib/tests/plugininfo/mod_test.php

@@ -32,21 +32,21 @@ class mod_test extends advanced_testcase {
     public function test_get_enabled_plugins(): void {
         $this->resetAfterTest();
 
-        // The bigbluebuttonbn plugin is disabled by default.
+        // The bigbluebuttonbn and chat plugins are disabled by default.
         // Check all default formats.
         $plugins = mod::get_enabled_plugins();
         $this->assertArrayHasKey('assign', $plugins);
-        $this->assertArrayHasKey('chat', $plugins);
         $this->assertArrayHasKey('forum', $plugins);
+        $this->assertArrayNotHasKey('chat', $plugins);
         $this->assertArrayNotHasKey('bigbluebuttonbn', $plugins);
 
         // Disable assignment.
         mod::enable_plugin('assign', 0);
 
         $plugins = mod::get_enabled_plugins();
-        $this->assertArrayHasKey('chat', $plugins);
         $this->assertArrayHasKey('forum', $plugins);
         $this->assertArrayNotHasKey('assign', $plugins);
+        $this->assertArrayNotHasKey('chat', $plugins);
         $this->assertArrayNotHasKey('bigbluebuttonbn', $plugins);
     }
 }

mod/chat/tests/dates_test.php

@@ -36,6 +36,15 @@
  */
 class dates_test extends advanced_testcase {
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
+    }
+
     /**
      * Data provider for get_dates_for_module().
      * @return array[]

mod/chat/tests/event/events_test.php

@@ -38,6 +38,15 @@
  */
 class events_test extends \advanced_testcase {
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
+    }
+
     public function test_message_sent() {
         global $DB;
         $this->resetAfterTest();

mod/chat/tests/external/view_sessions_test.php

@@ -54,7 +54,13 @@ class view_sessions_test extends externallib_advanced_testcase {
      */
     private function prepare_test_data(): array {
         global $DB;
+
         $this->resetAfterTest(true);
+
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
+
         $course = $this->getDataGenerator()->create_course();
         $student1 = $this->getDataGenerator()->create_and_enrol($course);
         $chat = $this->getDataGenerator()->create_module('chat', ['course' => $course->id]);

mod/chat/tests/externallib_test.php

@@ -37,6 +37,15 @@
  */
 class externallib_test extends externallib_advanced_testcase {
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
+    }
+
     /**
      * Test login user
      */

mod/chat/tests/generator_test.php

@@ -25,6 +25,15 @@
  */
 class generator_test extends \advanced_testcase {
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
+    }
+
     public function test_create_instance() {
         global $DB;
         $this->resetAfterTest();

mod/chat/tests/lib_test.php

@@ -38,6 +38,10 @@ class lib_test extends \advanced_testcase {
 
     public function setUp(): void {
         $this->resetAfterTest();
+
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
     }
 
     /*

mod/chat/tests/privacy/provider_test.php

@@ -52,6 +52,10 @@ public function setUp(): void {
         global $PAGE;
         $this->resetAfterTest();
         $PAGE->get_renderer('core');
+
+        // Chat module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('chat', 1);
     }
 
     public function test_get_contexts_for_userid() {

mod/survey/tests/event/events_test.php

@@ -38,6 +38,9 @@ class events_test extends \advanced_testcase {
      */
     public function setUp(): void {
         $this->resetAfterTest();
+        // Survey module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('survey', 1);
     }
 
     /**

mod/survey/tests/externallib_test.php

@@ -70,6 +70,10 @@ public function setUp(): void {
         $this->resetAfterTest();
         $this->setAdminUser();
 
+        // Survey module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('survey', 1);
+
         // Setup test data.
         $this->course = $this->getDataGenerator()->create_course();
         $this->survey = $this->getDataGenerator()->create_module('survey', array('course' => $this->course->id));

mod/survey/tests/generator_test.php

@@ -26,6 +26,15 @@
  */
 class generator_test extends \advanced_testcase {
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Survey module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('survey', 1);
+    }
+
     public function test_create_instance() {
         global $DB;
         $this->resetAfterTest();

mod/survey/tests/lib_test.php

@@ -48,6 +48,15 @@ public static function setUpBeforeClass(): void {
         require_once($CFG->dirroot . '/mod/survey/lib.php');
     }
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Survey module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('survey', 1);
+    }
+
     /**
      * Test survey_view
      * @return void

mod/survey/tests/privacy/provider_test.php

@@ -52,6 +52,10 @@ public function setUp(): void {
         global $PAGE;
         $this->resetAfterTest();
         $PAGE->get_renderer('core');
+
+        // Survey module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('survey', 1);
     }
 
     public function test_get_contexts_for_userid() {

mod/survey/tests/search/search_test.php

@@ -39,6 +39,15 @@
  */
 class search_test extends \advanced_testcase {
 
+    /**
+     * Setup testcase.
+     */
+    public function setUp(): void {
+        // Survey module is disabled by default, enable it for testing.
+        $manager = \core_plugin_manager::resolve_plugininfo_class('mod');
+        $manager::enable_plugin('survey', 1);
+    }
+
     /**
      * Test survey_view
      * @return void