MDL-81924 factor_sms: Improve MFA plugin table settings accessibility

abgreeve · Sep 23, 2024 · c098b72 · c098b72
1 parent d5bdb07
commit c098b72
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/admin/tool/mfa/classes/local/admin_setting_managemfa.php b/admin/tool/mfa/classes/local/admin_setting_managemfa.php
@@ -125,7 +125,12 @@ public function define_manage_mfa_table() {
         foreach ($factors as $factor) {
             $settingsparams = ['section' => 'factor_'.$factor->name];
             $settingsurl = new \moodle_url('settings.php', $settingsparams);
-            $settingslink = \html_writer::link($settingsurl, $txt->settings);
+            $settingslinkattrtext = get_string('editfactor', 'tool_mfa', $factor->get_display_name());
+            $settingslinkattr = [
+                'title' => $settingslinkattrtext,
+                'aria-label' => $settingslinkattrtext,
+            ];
+            $settingslink = \html_writer::link($settingsurl, $txt->settings, $settingslinkattr);
 
             if ($factor->is_enabled()) {
                 $hideshowparams = ['action' => 'disable', 'factor' => $factor->name, 'sesskey' => $sesskey];

diff --git a/admin/tool/mfa/lang/en/tool_mfa.php b/admin/tool/mfa/lang/en/tool_mfa.php
@@ -36,6 +36,7 @@
 $string['connector'] = 'AND';
 $string['debugmode:heading'] = 'Debug mode';
 $string['devicename'] = 'Device';
+$string['editfactor'] = 'Edit settings for the {$a} factor';
 $string['entercode'] = 'Enter code';
 $string['email:subject'] = 'Unable to log in to {$a}';
 $string['enablefactor'] = 'Enable factor';