MDL-81924 factor_sms: Remove leftover AWS implementation

Originally implemented as MDL-80962.

.upgradenotes/MDL-80962-2024071606510000.yml

@@ -0,0 +1,9 @@
+issueNumber: MDL-80962
+notes:
+  factor_sms:
+    - message: >
+        The following classes are removed as the SMS feature now takes advantage of core_sms API:
+        - sms_sent (admin/tool/mfa/factor/sms/classes/event/sms_sent.php)
+        - aws_sns (admin/tool/mfa/factor/sms/classes/local/smsgateway/aws_sns.php)
+        - gateway_interface (admin/tool/mfa/factor/sms/classes/local/smsgateway/gateway_interface.php)
+      type: removed

admin/tool/mfa/factor/sms/classes/factor.php

@@ -19,6 +19,7 @@
 use moodle_url;
 use stdClass;
 use tool_mfa\local\factor\object_factor_base;
+use tool_mfa\local\secret_manager;
 
 /**
  * SMS Factor implementation.
@@ -231,7 +232,7 @@ public function setup_factor_form_is_cancelled(int $factorid): void {
             unset($SESSION->tool_mfa_sms_number);
         }
         // Clean temp secrets code.
-        $secretmanager = new \tool_mfa\local\secret_manager('sms');
+        $secretmanager = new secret_manager('sms');
         $secretmanager->cleanup_temp_secrets();
     }
 
@@ -424,7 +425,7 @@ private function sms_verification_code(int $secret, ?string $phonenumber): void
      * @return bool
      */
     private function check_verification_code(string $enteredcode): bool {
-        return ($this->secretmanager->validate_secret($enteredcode) === \tool_mfa\local\secret_manager::VALID) ? true : false;
+        return $this->secretmanager->validate_secret($enteredcode) === secret_manager::VALID;
     }
 
     /**
@@ -453,8 +454,8 @@ public function get_login_desc(): string {
 
         if (empty($phonenumber)) {
             return get_string('errorsmssent', 'factor_sms');
-        } else {
-            return get_string('logindesc', 'factor_' . $this->name, $phonenumber);
         }
+
+        return get_string('logindesc', 'factor_' . $this->name, $phonenumber);
     }
 }

admin/tool/mfa/factor/sms/db/upgrade.php

@@ -60,5 +60,18 @@ classname: \smsgateway_aws\gateway::class,
         upgrade_plugin_savepoint(true, 2024082200, 'factor', 'sms');
     }
 
+    if ($oldversion < 2024082201) {
+        // Unset the removed admin settings.
+        unset_config('countrycode', 'factor_sms');
+        unset_config('gateway', 'factor_sms');
+        unset_config('usecredchain', 'factor_sms');
+        unset_config('api_key', 'factor_sms');
+        unset_config('api_secret', 'factor_sms');
+        unset_config('api_region', 'factor_sms');
+
+        // MFA savepoint reached.
+        upgrade_plugin_savepoint(true, 2024082201, 'factor', 'sms');
+    }
+
     return true;
 }

admin/tool/mfa/factor/sms/lang/en/deprecated.txt

@@ -0,0 +1,15 @@
+settings:countrycode,factor_sms
+settings:countrycode_help,factor_sms
+settings:aws,factor_sms
+settings:aws:key,factor_sms
+settings:aws:key_help,factor_sms
+settings:aws:region,factor_sms
+settings:aws:region_help,factor_sms
+settings:aws:secret,factor_sms
+settings:aws:secret_help,factor_sms
+settings:aws:usecredchain,factor_sms
+settings:gateway,factor_sms
+settings:gateway_help,factor_sms
+errorawsconection,factor_sms
+event:smssentdescription,factor_sms
+event:smssent,factor_sms