MDL-77825 grade_gradereport: MS SQL fix for user search

abgreeve · Apr 3, 2023 · d017cb5 · d017cb5
1 parent fba0658
commit d017cb5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/grade/report/lib.php b/grade/report/lib.php
@@ -479,7 +479,7 @@ public function setup_users() {
         // When a user wants to view a particular user rather than a set of users.
         // By omission when selecting one user, also allow passing the search value around.
         if ($this->userid !== -1) {
-            $this->userwheresql .= ' AND '.$DB->sql_equal('u.id', ':uid');
+            $this->userwheresql .= " AND u.id = :uid";
             $this->userwheresql_params['uid'] = $this->userid;
         }
 
@@ -493,7 +493,7 @@ public function setup_users() {
                 'where' => $keywordswhere,
                 'params' => $keywordsparams,
             ] = $this->get_users_search_sql($mappings, (array)$userfields);
-            $this->userwheresql = " AND $keywordswhere";
+            $this->userwheresql .= " AND $keywordswhere";
             $this->userwheresql_params = array_merge($this->userwheresql_params, $keywordsparams);
         }
     }