MDL-76052 webservice_xmlrpc: Remove it completely from core

Normal removal procedure:
  - Remove the plugin completely from core.
  - Document it in the webservices upgrade.txt file.
  - Add a core upgrade step to proceed to remove any configuration
    if the plugin has not been re-installed manually.

Plus:
  - Remove a few remaining uses in the hub/sites registration scripts,
    that were moved from xmlrpc to hand.made rest calls by MDL-31436
    (Moodle 3.4.1 and up) and never removed then.
  - Remove the php-xmlrpc extension as a recommendation in composer.
  - Remove "xmlrpc" from various comments, trivial cleanup.

Note:
  - While working on this MDL-76078 has been created about to
    fix a serious design problem detected (it does not affect
    functionality). That's out from this issue scope.

composer.json

@@ -48,7 +48,6 @@
         "ext-sqlsrv": "Needed when Moodle uses MS SQL Server database.",
         "ext-oci8": "Needed when Moodle uses Oracle database.",
         "ext-tokenizer": "Enabling Tokenizer PHP extension is recommended, it improves Moodle Networking functionality.",
-        "ext-xmlrpc": "Enabling XMLRPC PHP extension is useful for web services and Moodle networking.",
         "ext-soap": "Enabling SOAP PHP extension is useful for web services and some plugins.",
         "ext-sodium": "Enabling Sodium PHP extension is recommended, it is used by Moodle encryption API.",
         "ext-exif": "Enabling Exif PHP extension is recommended, it is used by Moodle to parse image meta data."

lib/classes/hub/api.php

@@ -25,7 +25,6 @@
 namespace core\hub;
 defined('MOODLE_INTERNAL') || die();
 
-use webservice_xmlrpc_client;
 use moodle_exception;
 use curl;
 use stdClass;
@@ -370,4 +369,4 @@ public static function download_course_backup($hubcourseid, $path) {
     public static function upload_course_backup($hubcourseid, \stored_file $backupfile) {
         debugging("This function has been deprecated as part of the Moodle.net sunsetting process.");
     }
-}
+}

lib/classes/plugin_manager.php

@@ -1745,7 +1745,7 @@ public static function is_deleted_standard_plugin($type, $name) {
                 'binarius', 'boxxie', 'brick', 'canvas', 'formal_white', 'formfactor', 'fusion', 'leatherbound',
                 'magazine', 'mymobile', 'nimble', 'nonzero', 'overlay', 'serenity', 'sky_high', 'splash',
                 'standard', 'standardold'),
-            'webservice' => array('amf'),
+            'webservice' => array('amf', 'xmlrpc'),
         );
 
         if (!isset($plugins[$type])) {
@@ -2047,7 +2047,7 @@ public static function standard_plugins_list($type) {
             ),
 
             'webservice' => array(
-                'rest', 'soap', 'xmlrpc'
+                'rest', 'soap'
             ),
 
             'workshopallocation' => array(

lib/classes/plugininfo/webservice.php

@@ -116,10 +116,6 @@ public function load_settings(part_of_admin_tree $adminroot, $parentnodename, $h
     }
 
     public function is_uninstall_allowed() {
-        // The xmlrpc plugin contains webservice_xmlrpc_client (used by core).
-        if ($this->name == 'xmlrpc') {
-            return false;
-        }
         return true;
     }
 }

lib/db/upgrade.php

@@ -3005,5 +3005,31 @@ function xmldb_main_upgrade($oldversion) {
         upgrade_main_savepoint(true, 2022102800.01);
     }
 
+    if ($oldversion < 2022110600.00) {
+        // If webservice_xmlrpc isn't any longer installed, remove its configuration,
+        // capabilities and presence in other settings.
+        if (!file_exists($CFG->dirroot . '/webservice/xmlrpc/version.php')) {
+            // No DB structures to delete in this plugin.
+
+            // Remove capabilities.
+            capabilities_cleanup('webservice_xmlrpc');
+
+            // Remove own configuration.
+            unset_all_config_for_plugin('webservice_xmlrpc');
+
+            // Remove it from the enabled protocols if it was there.
+            $protos = get_config('core', 'webserviceprotocols');
+            $protoarr = explode(',', $protos);
+            $protoarr = array_filter($protoarr, function($ele) {
+                return trim($ele) !== 'xmlrpc';
+            });
+            $protos = implode(',', $protoarr);
+            set_config('webserviceprotocols', $protos);
+        }
+
+        // Main savepoint reached.
+        upgrade_main_savepoint(true, 2022110600.00);
+    }
+
     return true;
 }

version.php

@@ -29,7 +29,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$version  = 2022110400.00;              // YYYYMMDD      = weekly release date of this DEV branch.
+$version  = 2022110600.00;              // YYYYMMDD      = weekly release date of this DEV branch.
                                         //         RR    = release increments - 00 in DEV branches.
                                         //           .XX = incremental changes.
 $release  = '4.1dev+ (Build: 20221104)'; // Human-friendly version name

webservice/lib.php

@@ -898,7 +898,7 @@ function __construct($debuginfo) {
 /**
  * Check if a protocol is enabled
  *
- * @param string $protocol name of WS protocol ('rest', 'soap', 'xmlrpc'...)
+ * @param string $protocol name of WS protocol ('rest', 'soap', ...)
  * @return bool true if the protocol is enabled
  */
 function webservice_protocol_is_enabled($protocol) {

webservice/upgrade.txt

@@ -3,10 +3,15 @@ information provided here is intended especially for developers.
 
 This information is intended for authors of webservices, not people writing webservice clients.
 
+=== 4.1 ===
+
+* The XMLRPC webservice (protocol) has been completely removed. It's now available in the plugins directory.
+
 === 4.0 ===
 
-* User access related exceptions have been changed to use the moodle_exception class instead of the generic webservice_access_exception,
-  the main reason for this change is to allow clients to implement some code logic against an access error.
+* User access related exceptions have been changed to use the moodle_exception class instead of the
+  generic webservice_access_exception, the main reason for this change is to allow clients to
+  implement some code logic against an access error.
 
 === 3.11 ===