MDL-80677 core: deprecation::from should always return

abgreeve · Mar 11, 2024 · f09d886 · f09d886
1 parent 57ec38d
commit f09d886
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/classes/deprecation.php b/lib/classes/deprecation.php
@@ -83,6 +83,9 @@ public static function from(array|string|object $reference): ?deprecated {
             // The reference is an array, but it's not an object or a class that currently exists.
             return null;
         }
+
+        // The reference is none of the above.
+        return null;
     }
 
     /**

diff --git a/lib/tests/deprecation_test.php b/lib/tests/deprecation_test.php
@@ -285,6 +285,9 @@ public static function from_provider(): array {
             // Deprecated global function.
             ['core\fixtures\deprecated_function', true],
             ['core\fixtures\not_deprecated_function', false],
+
+            // Empty array.
+            [[], false],
         ];
     }