Skip to content

Commit

Permalink
x86/mm: Fix range check in tlbflush debugfs interface
Browse files Browse the repository at this point in the history
Since the shift count settable there is used for shifting values
of type "unsigned long", its value must not match or exceed
BITS_PER_LONG (otherwise the shift operations are undefined).

Similarly, the value must not be negative (but -1 must be
permitted, as that's the value used to distinguish the case of
the fine grained flushing being disabled).

Signed-off-by: Jan Beulich <[email protected]>
Cc: Alex Shi <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
jbeulich authored and Ingo Molnar committed Sep 7, 2012
1 parent 057237b commit d4c9dbc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/mm/tlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ static ssize_t tlbflush_write_file(struct file *file,
if (kstrtos8(buf, 0, &shift))
return -EINVAL;

if (shift > 64)
if (shift < -1 || shift >= BITS_PER_LONG)
return -EINVAL;

tlb_flushall_shift = shift;
Expand Down

0 comments on commit d4c9dbc

Please sign in to comment.