Used colons for separating the line and column number in the prose fo…

…rmatter. (palantir#4222) Fixes palantir#3861.
abierbaum · Nov 5, 2018 · 0172fab · 0172fab
1 parent 1e9ed49
commit 0172fab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/formatters/proseFormatter.ts b/src/formatters/proseFormatter.ts
@@ -54,9 +54,11 @@ export class Formatter extends AbstractFormatter {
             const failureString = failure.getFailure();
 
             const lineAndCharacter = failure.getStartPosition().getLineAndCharacter();
-            const positionTuple = `[${lineAndCharacter.line + 1}, ${lineAndCharacter.character + 1}]`;
+            const positionTuple = `${lineAndCharacter.line + 1}:${lineAndCharacter.character + 1}`;
 
-            return `${failure.getRuleSeverity().toUpperCase()}: ${fileName}${positionTuple}: ${failureString}`;
+            return `${failure
+                .getRuleSeverity()
+                .toUpperCase()}: ${fileName}:${positionTuple} - ${failureString}`;
         });
 
         return `${fixLines.concat(errorLines).join("\n")}\n`;

diff --git a/test/formatters/proseFormatterTests.ts b/test/formatters/proseFormatterTests.ts
@@ -79,6 +79,6 @@ describe("Prose Formatter", () => {
     });
 
     function getPositionString(line: number, character: number) {
-        return `[${line}, ${character}]: `;
+        return `:${line}:${character} - `;
     }
 });