Add ldap travis tests

.travis.yml

@@ -4,6 +4,11 @@ jdk: oraclejdk7
 services:
   - mysql
   - postgresql
+addons:
+  apt:
+    packages:
+      - slapd
+      - ldap-utils
 python:
   - "2.7"
   - "3.4"

airflow/__init__.py

@@ -39,7 +39,7 @@ def load_login():
     try:
         global login
         login = import_module(auth_backend)
-    except ImportError, err:
+    except ImportError as err:
         logging.critical(
             "Cannot import authentication module %s. "
             "Please correct your authentication backend or disable authentication: %s",

airflow/www/app.py

@@ -23,10 +23,6 @@ def create_app(config=None):
 
     #app.config = config
     airflow.load_login()
-    airflow.login.login_manager = flask_login.LoginManager()
-    airflow.login.login_manager.login_view = 'airflow.login'
-    airflow.login.login_manager.login_message = None
-
     airflow.login.login_manager.init_app(app)
 
     cache = Cache(

scripts/ci/ldap.sh

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+
+DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
+LDAP_DB=/tmp/ldap_db
+
+echo "Creating database directory"
+
+rm -rf ${LDAP_DB} && mkdir ${LDAP_DB} && cp  /usr/share/doc/slapd/examples/DB_CONFIG ${LDAP_DB}
+
+echo "Launching OpenLDAP ..."
+
+# Start slapd with non root privileges
+slapd -h "ldap://127.0.0.1:3890/" -f ${DIR}/slapd.conf
+
+# Wait for LDAP to start
+sleep 1

scripts/ci/ldif/example.com.ldif

@@ -0,0 +1,6 @@
+dn: dc=example,dc=com
+dc: example
+description: LDAP Example
+objectClass: dcObject
+objectClass: organization
+o: example

scripts/ci/ldif/manager.example.com.ldif

@@ -0,0 +1,3 @@
+dn: cn=Manager,dc=example,dc=com
+cn: Manager
+objectClass: organizationalRole

scripts/ci/ldif/user1.example.com.ldif

@@ -0,0 +1,5 @@
+dn: uid=user1,dc=example,dc=com
+objectClass: account
+objectClass: simpleSecurityObject
+uid: user1
+userPassword: user1

scripts/ci/load_fixtures.sh

@@ -0,0 +1,13 @@
+#!/usr/bin/env bash
+
+DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
+FIXTURES_DIR="$DIR/ldif"
+
+load_fixture () {
+  ldapadd -x -H ldap://127.0.0.1:3890/ -D "cn=Manager,dc=example,dc=com" -w insecure -f $1
+}
+
+for FIXTURE in `ls ${FIXTURES_DIR}`
+do
+  load_fixture "${FIXTURES_DIR}/${FIXTURE}"
+done;

scripts/ci/slapd.conf

@@ -0,0 +1,44 @@
+##
+# Global Directives
+##
+
+# Schema and objectClass definitions
+include         /etc/ldap/schema/core.schema
+include         /etc/ldap/schema/cosine.schema
+include         /etc/ldap/schema/nis.schema
+include         /etc/ldap/schema/inetorgperson.schema
+
+moduleload back_hdb
+
+disallow bind_anon
+
+##
+# Test DB
+##
+
+database hdb
+
+suffix "dc=example,dc=com"
+
+rootdn "cn=Manager,dc=example,dc=com"
+rootpw insecure
+
+# The database directory MUST exist prior to running slapd AND
+# change path as necessary
+directory       /tmp/ldap_db/
+
+##
+# ACL
+##
+
+# The userPassword by default can be changed
+# by the entry owning it if they are authenticated.
+# Others should not be able to see it, except the
+# admin entry below
+# These access lines apply to database #1 only
+access to attrs=userPassword
+  by self write
+  by anonymous auth
+  by users none
+
+access to * by * read

tests/core.py

@@ -458,7 +458,7 @@ def setUp(self):
             configuration.conf.add_section("ldap")
         except:
             pass
-        configuration.conf.set("ldap", "uri", "ldap://localhost")
+        configuration.conf.set("ldap", "uri", "ldap://localhost:3890")
         configuration.conf.set("ldap", "user_filter", "objectClass=*")
         configuration.conf.set("ldap", "user_name_attr", "True")
         configuration.conf.set("ldap", "bind_user", "cn=Manager,dc=example,dc=com")
@@ -483,23 +483,21 @@ def logout(self):
     def test_login_logout_ldap(self):
         assert configuration.conf.getboolean('webserver', 'authenticate') is True
 
-        #response = self.login('user1', 'userx')
-        #print(response.data)
-        #assert 'Incorrect login details' in response.data
+        response = self.login('user1', 'userx')
+        assert 'Incorrect login details' in response.data
 
-        #response = self.login('userz', 'user1')
-        #assert 'Incorrect login details' in response.data
+        response = self.login('userz', 'user1')
+        assert 'Incorrect login details' in response.data
 
-        #response = self.login('user1', 'user1')
-        #assert 'Data Profiling' in response.data
+        response = self.login('user1', 'user1')
+        assert 'Data Profiling' in response.data
 
-        #response = self.logout()
-        #assert 'form-signin' in response.data
+        response = self.logout()
+        assert 'form-signin' in response.data
 
     def test_unauthorized(self):
-        response = self.app.get("/")
-        print response.data
-        assert '403 Forbidden' in response.data
+        response = self.app.get("/admin/airflow/landing_times")
+        self.assertEqual(response.status_code, 302)
 
     def tearDown(self):
         configuration.test_mode()

tox.ini

@@ -39,5 +39,7 @@ commands =
   pip install --find-links={homedir}/.wheelhouse --no-index -rrequirements.txt
 #  {toxinidir}/scripts/ci/setup_kdc.sh
   {toxinidir}/scripts/ci/setup_env.sh
+  {toxinidir}/scripts/ci/ldap.sh
+  {toxinidir}/scripts/ci/load_fixtures.sh
   {toxinidir}/scripts/ci/run_tests.sh []
   coveralls