Ward for None in is_valid_object()

abriemme · Oct 13, 2022 · 29aaf77 · 29aaf77
1 parent e5eaa11
commit 29aaf77
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/djstripe/models/base.py b/djstripe/models/base.py
@@ -506,7 +506,7 @@ def is_valid_object(cls, data):
         """
         Returns whether the data is a valid object for the class
         """
-        return "object" in data and data["object"] == cls.stripe_class.OBJECT_NAME
+        return data and data.get("object") == cls.stripe_class.OBJECT_NAME
 
     def _attach_objects_hook(
         self, cls, data, api_key=djstripe_settings.STRIPE_SECRET_KEY, current_ids=None

diff --git a/djstripe/models/billing.py b/djstripe/models/billing.py
@@ -1045,7 +1045,7 @@ def __str__(self):
 
     @classmethod
     def is_valid_object(cls, data):
-        return "object" in data and data["object"] in ("invoiceitem", "line_item")
+        return data and data.get("object") in ("invoiceitem", "line_item")
 
     def get_stripe_dashboard_url(self):
         return self.invoice.get_stripe_dashboard_url()

diff --git a/djstripe/models/connect.py b/djstripe/models/connect.py
@@ -374,4 +374,4 @@ def is_valid_object(cls, data):
         """
         Returns whether the data is a valid object for the class
         """
-        return "object" in data and data["object"] == "transfer_reversal"
+        return data and data.get("object") == "transfer_reversal"
diff --git a/djstripe/models/core.py b/djstripe/models/core.py
@@ -1654,7 +1654,7 @@ class File(StripeModel):
 
     @classmethod
     def is_valid_object(cls, data):
-        return "object" in data and data["object"] in ("file", "file_upload")
+        return data and data.get("object") in ("file", "file_upload")
 
     def __str__(self):
         return f"{self.filename}, {enums.FilePurpose.humanize(self.purpose)}"