Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support highlighting comments #20

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

taquangtrung
Copy link
Contributor

Hi,

I created a syntax table, which allows mermaid-mode to highlight comments, as in the attached screenshot.

mermaid

Can you consider merging this PR?

Thank you!

mermaid-mode.el Outdated Show resolved Hide resolved
mermaid-mode.el Outdated Show resolved Hide resolved
@abrochard
Copy link
Owner

Thank you for submitting this! I left some minor comments. Looks good otherwise.

@taquangtrung
Copy link
Contributor Author

@abrochard : Thanks for the comments! I have updated the code as suggested.
Can you check it again?

Copy link
Owner

@abrochard abrochard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@abrochard abrochard merged commit 1a6526b into abrochard:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants