Rework project structure #126
Conversation
arron-speake-bluefruit
force-pushed
the
structure-rework
branch
from
22b0526 to
21ef9f8
Compare
|
Should '.cargo-ok' be part of this PR? |
| # Using x.py | ||
|
|
||
| The intended way to build loadstone is using the x.py script in the root of the project. For usage information do `./x.py help SUBCOMMAND`. | ||
|
|
There was a problem hiding this comment.
What's the reason for calling it x.py?
There was a problem hiding this comment.
its named after a similar tool in the rustc repo, short for execute. wasn't sure on a proper name so i just went with it
| @@ -2,13 +2,14 @@ FROM rust:buster | |||
|
|
|||
There was a problem hiding this comment.
is the docker container used? If so, has its version been updated?
There was a problem hiding this comment.
the docker container gets used for github actions, dockerhub has been update with this new version
| @@ -7,7 +7,7 @@ use ufmt::{uwrite, uwriteln}; | |||
| /// Top level error type for the bootloader. Unlike the specific | |||
| /// module errors, this error contains textual descriptions of the | |||
| /// problem as it is meant to be directly reported through USART. | |||
| #[derive(Debug, Copy, Clone, PartialEq, Format)] | |||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Format)] | |||
There was a problem hiding this comment.
Why do you need Eq?
There was a problem hiding this comment.
its not strictly required, it just tells the compiler that the Error type has a proper equivalence relation instead of a partial equivalence relation.
the general advice is to derive it where possible, since it lets the compiler perform more aggressive optimizations
rustfmt.