Windows: Detach console on startup (onivim#401)

* Detach console on startup for windows

* Only detach if logging is not enabled

* Formatting

* Format c bindings

src/editor/Core/Cli.re

@@ -37,6 +37,11 @@ let parse = (setup: Setup.t) => {
     header(setup.version),
   );
 
+  if (! Log.canPrint^) {
+    /* On Windows, detach the application from the console if we're not logging to console */
+    Utility.freeConsole();
+  };
+
   let paths = args^ |> List.rev;
   let workingDirectory = Environment.getWorkingDirectory();
 

src/editor/Core/Utility.re

@@ -144,3 +144,5 @@ let trimTrailingSlash = (item: string) => {
     item;
   };
 };
+
+external freeConsole: unit => unit = "win32_free_console";

src/editor/Core/bindings.c

@@ -0,0 +1,20 @@
+#include <stdio.h>
+
+#include <caml/alloc.h>
+#include <caml/callback.h>
+#include <caml/memory.h>
+#include <caml/mlvalues.h>
+
+#ifdef WIN32
+#include <Windows.h>
+#endif
+
+CAMLprim value win32_free_console(value unit) {
+
+#ifdef WIN32
+  printf("yo from c\n");
+  FreeConsole();
+#endif
+
+  return Val_unit;
+};

src/editor/Core/dune

@@ -1,6 +1,7 @@
 (library
     (name Oni_Core)
     (public_name Oni2.core)
+    (c_names bindings)
     (libraries 
         str
         bigarray