Skip to content

Commit

Permalink
requests.storage is a standard resource name
Browse files Browse the repository at this point in the history
  • Loading branch information
derekwaynecarr committed Oct 19, 2016
1 parent 91b7e1f commit d5c45e8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/api/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ var standardResources = sets.NewString(
string(ResourceConfigMaps),
string(ResourcePersistentVolumeClaims),
string(ResourceStorage),
string(ResourceRequestsStorage),
)

// IsStandardResourceName returns true if the resource is known to the system
Expand Down
6 changes: 6 additions & 0 deletions pkg/api/validation/validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6495,6 +6495,12 @@ func TestValidateResourceNames(t *testing.T) {
}{
{"memory", true, ""},
{"cpu", true, ""},
{"storage", true, ""},
{"requests.cpu", true, ""},
{"requests.memory", true, ""},
{"requests.storage", true, ""},
{"limits.cpu", true, ""},
{"limits.memory", true, ""},
{"network", false, ""},
{"disk", false, ""},
{"", false, ""},
Expand Down

0 comments on commit d5c45e8

Please sign in to comment.