Skip to content

Commit

Permalink
typo in image links
Browse files Browse the repository at this point in the history
  • Loading branch information
acen23 committed Mar 11, 2022
1 parent c4ba471 commit f3bec00
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lab-report-5.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ by Andrew Cen
## Test For File 194.md
- For both implementations, these were the outputs (top output is the class implementation, bottom is personal implementation): ![194output](https://acen23.github.io/cse15l-lab-reports/lib5/194.png)
- The expected output should be a list with the url "my_(url)". Therefore, neither implementation has the correct output.
- The part of the code for the personal implementation that has the bug is here: ![194error](https://acen23.github.io/cse15l-lab-reports/lib5/194error.png) The implementation fails to parse links that do not have parentheses surrounding their urls. This syntax works as a link according to [commonmark](https://spec.commonmark.org/dingus/). The implementation should instead look out for urls following the colon after an open and closed bracket.
- The part of the code for the personal implementation that has the bug is here: ![194error](https://acen23.github.io/cse15l-lab-reports/lib5/error194.png) The implementation fails to parse links that do not have parentheses surrounding their urls. This syntax works as a link according to [commonmark](https://spec.commonmark.org/dingus/). The implementation should instead look out for urls following the colon after an open and closed bracket.

## Test For File 201.md
- For both implementations, these were the outputs: ![201output](https://acen23.github.io/cse15l-lab-reports/lib5/194.png)
- The expected output should be an empty list. Therefore, the personal implementation has the correct output.
- The part of the code for the class implementation that has the bug is here: ![201error](https://acen23.github.io/cse15l-lab-reports/lib5/201error.png) The implementation incorrectly parses links that have characters between the end bracket and open parentheses of a potential link. The implementation should instead add a check to see if the next char after the pair of brackets is an open parentheses before parsing as a valid link.
- The part of the code for the class implementation that has the bug is here: ![201error](https://acen23.github.io/cse15l-lab-reports/lib5/error201.png) The implementation incorrectly parses links that have characters between the end bracket and open parentheses of a potential link. The implementation should instead add a check to see if the next char after the pair of brackets is an open parentheses before parsing as a valid link.

0 comments on commit f3bec00

Please sign in to comment.