Win_hostname module: Change name check to WMI (ansible#56420)

* Change name check to WMI * Changelog fragment * Fixed per review
acozine · May 28, 2019 · 94566ed · 94566ed
1 parent 35c8739
commit 94566ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/56420-Fix-win_hostname-for-non-netbios-names.yml b/changelogs/fragments/56420-Fix-win_hostname-for-non-netbios-names.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- "win_hostname - Fix non netbios compliant name handling (https://github.com/ansible/ansible/issues/55283)"
diff --git a/lib/ansible/modules/windows/win_hostname.ps1 b/lib/ansible/modules/windows/win_hostname.ps1
@@ -11,7 +11,8 @@ $params = Parse-Args $args -supports_check_mode $true
 $name = Get-AnsibleParam -obj $params -name "name" -type "str" -failifempty $true
 $check_mode = Get-AnsibleParam -obj $params -name "_ansible_check_mode" -type "bool" -default $false
 
-$current_computer_name = $env:ComputerName
+$current_computer_name = (Get-CimInstance -Class Win32_ComputerSystem).DNSHostname
+
 $result = @{
    changed = $false
    old_name = $current_computer_name
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- "win_hostname - Fix non netbios compliant name handling (https://github.com/ansible/ansible/issues/55283)"