Reduce redundant calculations

Reduce redundant calculations of `amountIn.mul(997)` in the function `_swap` of contract `SushiMaker.sol`
actingcoach · Apr 22, 2021 · cbccf12 · cbccf12
1 parent d49f444
commit cbccf12
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/contracts/SushiMaker.sol b/contracts/SushiMaker.sol
@@ -237,14 +237,14 @@ contract SushiMaker is Ownable {
         uint256 amountInWithFee = amountIn.mul(997);
         if (fromToken == pair.token0()) {
             amountOut =
-                amountIn.mul(997).mul(reserve1) /
+                amountInWithFee.mul(reserve1) /
                 reserve0.mul(1000).add(amountInWithFee);
             IERC20(fromToken).safeTransfer(address(pair), amountIn);
             pair.swap(0, amountOut, to, new bytes(0));
             // TODO: Add maximum slippage?
         } else {
             amountOut =
-                amountIn.mul(997).mul(reserve0) /
+                amountInWithFee.mul(reserve0) /
                 reserve1.mul(1000).add(amountInWithFee);
             IERC20(fromToken).safeTransfer(address(pair), amountIn);
             pair.swap(amountOut, 0, to, new bytes(0));