Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ (typescript) convert Balance.jsx to .tsx #3874
♻️ (typescript) convert Balance.jsx to .tsx #3874
Changes from 1 commit
92ff91d
2675e91
48d632c
ebeb5da
8229290
b26d36c
5d13180
a6938e6
73316b4
13700ea
7a5f5f1
ac135af
b8cf7f7
5ab74fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 23 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 24 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 25 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 26 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 28 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 51 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 51 in packages/desktop-client/src/components/accounts/Balance.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this always returns an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const ids = new Set((rows || []).map(r => r.id));
complains because useSheetValue doesn't always return an array. It can return a number.
Check warning on line 69 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 99 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 101 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 125 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 137 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 140 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 146 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 154 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 154 in packages/desktop-client/src/components/accounts/Balance.tsx
Check warning on line 155 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 155 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 161 in packages/desktop-client/src/components/accounts/Balance.tsx
Check failure on line 162 in packages/desktop-client/src/components/accounts/Balance.tsx