Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo only] goal templates UI #3918

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jfdoming
Copy link
Contributor

@jfdoming jfdoming commented Dec 1, 2024

No description provided.

Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit ce6e7dd
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/674bb5a3e2d9ba00085899f1
😎 Deploy Preview https://deploy-preview-3918.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jfdoming jfdoming added the do not merge Don't merge this!!! label Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.45 MB → 5.46 MB (+10.35 kB) +0.19%
Changeset
File Δ Size
src/components/budget/goals/EditTemplate.tsx 🆕 +4.61 kB 0 B → 4.61 kB
src/components/budget/goals/reducer.ts 🆕 +2.12 kB 0 B → 2.12 kB
src/components/budget/goals/GoalButton.tsx 🆕 +1.38 kB 0 B → 1.38 kB
src/components/modals/GoalsEditModal.tsx 🆕 +869 B 0 B → 869 B
src/components/budget/goals/actions.ts 🆕 +232 B 0 B → 232 B
src/components/budget/goals/constants.ts 🆕 +156 B 0 B → 156 B
src/components/settings/Experimental.tsx 📈 +493 B (+12.52%) 3.85 kB → 4.33 kB
src/hooks/useFeatureFlag.ts 📈 +33 B (+9.82%) 336 B → 369 B
src/components/budget/SidebarCategory.tsx 📈 +344 B (+6.49%) 5.18 kB → 5.51 kB
src/style/styles.ts 📈 +135 B (+2.90%) 4.55 kB → 4.68 kB
src/components/Modals.tsx 📈 +132 B (+0.84%) 15.43 kB → 15.56 kB
src/components/util/GenericInput.jsx 📈 +38 B (+0.61%) 6.04 kB → 6.08 kB
src/components/modals/EditRuleModal.jsx 📉 -134 B (-0.33%) 39.65 kB → 39.52 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.44 MB → 3.45 MB (+8.63 kB) +0.25%
static/js/wide.js 241.19 kB → 242.91 kB (+1.72 kB) +0.71%
static/js/AppliedFilters.js 21.32 kB → 21.7 kB (+392 B) +1.80%

Smaller

Asset File Size % Changed
static/js/ReportRouter.js 1.52 MB → 1.52 MB (-392 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/useAccountPreviewTransactions.js 1.68 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 82.93 kB 0%

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.32 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.32 MB 0%

@youngcw
Copy link
Member

youngcw commented Dec 3, 2024

One possible thing to add would be to split the templates up into their types and a user needs to select the type they are going to make. The primary reason for this would be to give a description of each type of template in the app. Splitting up by type probably would make the template options simple to setup since they can be specific to template type.

That does get away from what had been discussed before about fully natural language templates, but it does give the user a quick view of the overall options without having to try every combination of entry to see whats doable.

Copy link
Contributor

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants