Fix electron translations #4317

MikesGlitch · 2025-02-06T17:39:55Z

Translations were in an infinite loop, constantly being set, which was causing unintended ui behaviour.

netlify · 2025-02-06T17:40:12Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`0967673`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67a4fa4bb3afc100085d0a54
😎 Deploy Preview	https://deploy-preview-4317.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-02-06T17:41:25Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	6.81 MB → 6.81 MB (+56 B)	+0.00%

Changeset

File	Δ	Size
`src/i18n.ts`	📈 +56 B (+2.35%)	2.33 kB → 2.39 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	4.29 MB → 4.29 MB (+56 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/nl.js	83.87 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/de.js	96.74 kB	0%
static/js/en.js	99.34 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/en-GB.js	99.33 kB	0%
static/js/pt-BR.js	103.29 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	84.94 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/AppliedFilters.js	10.52 kB	0%
static/js/wide.js	102.8 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

github-actions · 2025-02-06T17:41:27Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

bin/package-electron

packages/desktop-client/src/i18n.ts

coderabbitai · 2025-02-06T18:10:10Z

Walkthrough

The changes include updates to both a Bash script used for building an Electron package and an internationalization file. In the Bash script (bin/package-electron), a new section has been added to manage translations: it checks for the existence of a locale directory within the desktop client package, clones a translations repository if needed, pulls the latest updates, and runs a script to remove untranslated languages. The existing build logic, including handling release mode and Windows certificate password input, remains intact. In the internationalization file (packages/desktop-client/src/i18n.ts), an early exit has been implemented in the setI18NextLanguage function to prevent redundant language changes when the requested language is already active.

Possibly related PRs

Add language setting #4112: Addresses modifications in the setI18NextLanguage function, directly aligning with the changes in the i18n file.
Fix translations missing from preview deploys #4130: Involves handling translation management in the locale directory through cloning and updating translations, similar to the Bash script modifications.
Upload translations on builds of master #4002: Focuses on translation management in a Bash script for loading and uploading translations, closely relating to the new translation handling logic.

Suggested labels

:sparkles: Merged

Suggested reviewers

jfdoming
youngcw

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1529870 and 0967673.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4317.md is excluded by !**/*.md

📒 Files selected for processing (2)

bin/package-electron (1 hunks)
packages/desktop-client/src/i18n.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Visual regression
GitHub Check: Functional
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (2)

bin/package-electron (1)

39-47: Consider improving error handling and code reuse.

Consider reusing the translation filtering code from package-browser for consistency.

Add error handling for git operations to gracefully handle network issues or repository access problems.

Apply this diff to improve error handling:
 # Get translations
 echo "Updating translations..."
+
+handle_error() {
+    echo "Error: $1"
+    exit 1
+}
+
 if ! [ -d packages/desktop-client/locale ]; then
-    git clone https://github.com/actualbudget/translations packages/desktop-client/locale
+    git clone https://github.com/actualbudget/translations packages/desktop-client/locale || handle_error "Failed to clone translations repository"
 fi
 pushd packages/desktop-client/locale > /dev/null
-git pull
+git pull || handle_error "Failed to update translations"
 popd > /dev/null
-packages/desktop-client/bin/remove-untranslated-languages
+packages/desktop-client/bin/remove-untranslated-languages || handle_error "Failed to remove untranslated languages"
packages/desktop-client/src/i18n.ts (1)

80-82: LGTM! Good optimization.

The early return prevents unnecessary language changes when the requested language is already set. The comment style matches the suggestion from the past review.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

* fix electron translations

fix electron translations

c8fe224

actual-github-bot bot added the 🚧 WIP label Feb 6, 2025

matt-fidd reviewed Feb 6, 2025

View reviewed changes

bin/package-electron Outdated Show resolved Hide resolved

matt-fidd reviewed Feb 6, 2025

View reviewed changes

packages/desktop-client/src/i18n.ts Outdated Show resolved Hide resolved

MikesGlitch added 2 commits February 6, 2025 17:56

cleanup

c1b7095

release note

ee298c6

matt-fidd reviewed Feb 6, 2025

View reviewed changes

packages/desktop-client/src/i18n.ts Outdated Show resolved Hide resolved

typo

0967673

MikesGlitch marked this pull request as ready for review February 6, 2025 18:07

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Feb 6, 2025

matt-fidd approved these changes Feb 6, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Feb 6, 2025

MikesGlitch merged commit f5b9a5b into actualbudget:master Feb 6, 2025
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Feb 6, 2025

MikesGlitch deleted the fix/electron-translations branch February 6, 2025 18:16

matt-fidd pushed a commit that referenced this pull request Feb 6, 2025

Fix electron translations (#4317)

fd42689

* fix electron translations

coderabbitai bot mentioned this pull request Feb 20, 2025

📚 Start the application with the browser default language #4415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix electron translations #4317

Fix electron translations #4317

MikesGlitch commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

coderabbitai bot commented Feb 6, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Fix electron translations #4317

Fix electron translations #4317

Conversation

MikesGlitch commented Feb 6, 2025 • edited Loading

netlify bot commented Feb 6, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 6, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Feb 6, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Feb 6, 2025

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

MikesGlitch commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)