☁️ Server workflows run only when server files have changed #4348

MikesGlitch · 2025-02-10T20:54:15Z

Running the server workflows only when server files are changed.

The docker images take a while to build, this should speed up most PR's.

netlify · 2025-02-10T20:54:36Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`1b5fcec`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67aa6e60cd5a85000848a77e
😎 Deploy Preview	https://deploy-preview-4348.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2025-02-10T20:57:02Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	6.83 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/en.js	99.43 kB	0%
static/js/en-GB.js	99.33 kB	0%
static/js/de.js	110.85 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/narrow.js	84.94 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/nl.js	94.83 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/pt-BR.js	104.03 kB	0%
static/js/AppliedFilters.js	10.52 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/wide.js	102.8 kB	0%
static/js/ReportRouter.js	1.59 MB	0%
static/js/index.js	4.29 MB	0%

github-actions · 2025-02-10T20:57:03Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.33 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.33 MB	0%

coderabbitai · 2025-02-10T21:00:07Z

Warning

Rate limit exceeded

@MikesGlitch has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9fecc65 and 1b5fcec.

📒 Files selected for processing (2)

.github/workflows/e2e-test.yml (1 hunks)
.github/workflows/size-compare.yml (1 hunks)

Walkthrough

The pull request includes modifications to the GitHub Actions workflow for building the Edge Docker image, specifically updating the push and pull_request events to only trigger on changes within the packages/sync-server directory. This replaces the previous configuration that ignored certain files. Additionally, changes to the Express application's /transactions endpoint improve the logging of accountId and startDate by logging them as a structured object instead of separate variables. Furthermore, the error handling middleware in packages/sync-server/src/util/middlewares.js has been updated to log the request URL and the complete error object, enhancing the clarity of error logs. There were no changes to the functional aspects or public declarations of entities.

Possibly related PRs

👷 Prep work for merging actual-server into actual repo #4160: This PR modifies ESLint settings to ignore the same packages/sync-server path, directly relating to the modifications in the directory.

Suggested labels

:sparkles: Merged

Suggested reviewers

matt-fidd

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac08b87 and b790190.

⛔ Files ignored due to path filters (1)

upcoming-release-notes/4348.md is excluded by !**/*.md

📒 Files selected for processing (3)

.github/workflows/docker-edge.yml (1 hunks)
packages/sync-server/src/app-simplefin/app-simplefin.js (1 hunks)
packages/sync-server/src/util/middlewares.js (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/sync-server/src/app-simplefin/app-simplefin.js

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: Functional
GitHub Check: Visual regression
GitHub Check: build (macos-latest)
GitHub Check: build (windows-latest)
GitHub Check: build (ubuntu-latest)

🔇 Additional comments (1)

.github/workflows/docker-edge.yml (1)

14-15: Verify path filter coverage for server-related files.

The path filter ensures that the workflow runs only when changes are made to packages/sync-server. This aligns with the PR objective of optimizing server workflows.

Run the following script to verify if there are any server-related files outside the packages/sync-server directory:
✅ Verification successful

🏁 Script executed:
#!/bin/bash
# Description: Search for server-related files outside packages/sync-server.

# Test: Search for server-related files. Expect: No server files outside packages/sync-server.
fd -t f -E 'packages/sync-server' -E '.git' -E 'node_modules' \
  --exec rg -l -i 'server|express|http|api|endpoint|route|middleware'
Length of output: 57260

Path Filter Verification for sync-server Workflow

The script confirms that many files contain server-related keywords outside of the packages/sync-server directory. This is expected because the workflow in .github/workflows/docker-edge.yml is intentionally scoped to trigger only on changes inside packages/sync-server—aligning with the PR’s objective of optimizing server workflows by focusing exclusively on that component.

The current filter excludes other server-related files (e.g., those in packages/api or packages/loot-core/src/server), which is the intended behavior.

packages/sync-server/src/util/middlewares.js

packages/sync-server/src/app-simplefin/app-simplefin.js

making the server workflows run only when server files have changed

52908d2

actual-github-bot bot added the 🚧 WIP label Feb 10, 2025

release notes

b790190

MikesGlitch marked this pull request as ready for review February 10, 2025 20:56

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Feb 10, 2025

MikesGlitch changed the title ~~Making server workflows run only when server files have changed~~ Server workflows run only when server files have changed Feb 10, 2025

also on merge to master

c6cb977

coderabbitai bot reviewed Feb 10, 2025

View reviewed changes

packages/sync-server/src/util/middlewares.js Outdated Show resolved Hide resolved

MikesGlitch added 2 commits February 10, 2025 21:03

rabbit suggestion

9fecc65

e2e tests and size compare dont need to run when server changes

257da03

MikesGlitch commented Feb 10, 2025

View reviewed changes

packages/sync-server/src/app-simplefin/app-simplefin.js Show resolved Hide resolved

adding to the paths ignore

1b5fcec

MikesGlitch changed the title ~~Server workflows run only when server files have changed~~ ☁️ Server workflows run only when server files have changed Feb 10, 2025

youngcw approved these changes Feb 10, 2025

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Feb 10, 2025

MikesGlitch merged commit be2126e into actualbudget:master Feb 10, 2025
21 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Feb 10, 2025

MikesGlitch deleted the server-workflows-run-only-when-server-changed branch February 10, 2025 22:46

This was referenced Feb 10, 2025

⚒ Workflow updates to only trigger when needed #4352

Merged

Updating sync server package name to @actual-app/sync-server #4370

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

☁️ Server workflows run only when server files have changed #4348

☁️ Server workflows run only when server files have changed #4348

MikesGlitch commented Feb 10, 2025 •

edited

Loading

netlify bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

coderabbitai bot commented Feb 10, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

☁️ Server workflows run only when server files have changed #4348

☁️ Server workflows run only when server files have changed #4348

Conversation

MikesGlitch commented Feb 10, 2025 • edited Loading

netlify bot commented Feb 10, 2025 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 10, 2025 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Feb 10, 2025 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Feb 10, 2025 • edited Loading

Rate limit exceeded

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

MikesGlitch commented Feb 10, 2025 •

edited

Loading

netlify bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

coderabbitai bot commented Feb 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)