Documenting the repo move #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
actual-github-bot
bot
added
🔍 Ready for review
jfdoming
added
the
Merge at Software Release
jfdoming
approved these changes
Feb 9, 2025
docs/actual-server-repo-move.md
Outdated
| @@ -0,0 +1,43 @@ | |||
| # Actual Server repository move | |||
|
|
|||
| In February 2025 we will begin the process of merging the actual-server repository into the Actual workspace. | |||
There was a problem hiding this comment.
nit: if we plan to merge this PR only after the server merge, maybe reword to:
Suggested change
| In February 2025 we will begin the process of merging the actual-server repository into the Actual workspace. | |
| In February 2025 we merged the `actual-server` repository into the Actual workspace. |
There was a problem hiding this comment.
Ah I see, this is a temporary measure to prevent confusion. ff to ignore this suggestion for now then
docs/actual-server-repo-move.md
Outdated
| - Streamlined Development: Developers will only need to clone/sync one repo instead of two. | ||
| - Improved Debugging: It makes end-to-end debugging for server/client easier as they will be in the same workspace. | ||
| - Simplified Desktop App Packaging: Enables the desktop app to embed the sync server. | ||
| - Ensuring code consistency and reducing the maintenance burden. |
There was a problem hiding this comment.
Also would add it makes the releasing process easier for us (as I understand we no longer need to publish the npm web package and hence deal with all the specific ordering of the release process related to that)
actual-github-bot
bot
added
✅ Approved
actual-github-bot
bot
added
🔍 Ready for review
actual-github-bot
bot
added
✨ Merged
and removed
🔍 Ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting the repo move. I'll attach this doc to the Server readme so people are more informed
https://deploy-preview-629.www.actualbudget.org/docs/actual-server-repo-move