Skip to content

Commit

Permalink
Fixed ros service call parameter order. Now the parameters are transm…
Browse files Browse the repository at this point in the history
…itted by name instead of array order.
  • Loading branch information
Pro committed Nov 7, 2013
1 parent 55d35ac commit ab9af49
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 13 deletions.
7 changes: 1 addition & 6 deletions build/roslib.js
Original file line number Diff line number Diff line change
Expand Up @@ -724,16 +724,11 @@ ROSLIB.Service.prototype.callService = function(request, callback, failedCallbac
}
});

var requestValues = [];
Object.keys(request).forEach(function(name) {
requestValues.push(request[name]);
});

var call = {
op : 'call_service',
id : serviceCallId,
service : this.name,
args : requestValues
args : request
};
this.ros.callOnConnection(call);
};
Expand Down
Loading

0 comments on commit ab9af49

Please sign in to comment.