Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definitions for addContext #177

Closed
wants to merge 1 commit into from
Closed

Typescript definitions for addContext #177

wants to merge 1 commit into from

Conversation

eMuonTau
Copy link

@eMuonTau eMuonTau commented Aug 5, 2017

No description provided.

@adamgruber
Copy link
Owner

This project doesn't currently use Typescript.

@eMuonTau
Copy link
Author

eMuonTau commented Aug 5, 2017

I am using mochawesome in many Typescript projects including Angular 2+ projects. This definition provides type checking and intellisense in TS files. It will be good if you can distribute this definition with package.

@eMuonTau eMuonTau closed this Mar 25, 2018
@AerionDyseti
Copy link

Even though mochawesome itself isn't written in Typescript, this edit would make it much easier to utilize addContext for those who do. It would also provide intellisense for common editors like VS Code.

@adamgruber
Copy link
Owner

I realize there is a use for adding these type definitions. An alternate solution to adding these within the project itself is to open a PR on https://github.com/DefinitelyTyped/DefinitelyTyped. The definitions could then be published under the @types/mochawesome name.

One of my concerns is that I honestly don't know a whole lot about creating type definitions. Therefore I cannot speak to the accuracy of this implementation and don't feel comfortable including the file in this project without some kind of validation that it is correct. Further, once included, maintaining the type definitions becomes an added responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants