Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding the console reporter #283

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Allow overriding the console reporter #283

merged 3 commits into from
Jul 29, 2019

Conversation

tylerlevine
Copy link
Contributor

I wanted to be able to override the console reporter when using mochawesome, but found that this wasn't supported. This PR adds support for this feature via the consoleReporter reporter option.

@adamgruber
Copy link
Owner

Thanks for the PR. I've been wanting to offer this option for awhile. A few questions:

  • Do you think the quiet flag should silence the console reporter?
  • Should there be another way to turn off the console reporter?

Also, mind updating the README to include this new option?

@tylerlevine
Copy link
Contributor Author

Do you think the quiet flag should silence the console reporter?

Yep, that sounds reasonable.

Should there be another way to turn off the console reporter?

Maybe allowing consoleReporter to be set to "none" to disable entirely makes sense? Do we need this as well as the quiet flag? Does quiet turn off more things than just the console reporter?

WIll also update README

@tylerlevine tylerlevine force-pushed the allow-console-reporter-override branch 3 times, most recently from 0109717 to baae4e7 Compare June 21, 2019 16:33
@adamgruber
Copy link
Owner

Finally had some time to review this.

  • I think the quiet option should stay as is and not pertain to the console reporter. I don't think its necessary and we avoid a breaking change by leaving it alone.
  • I like using the consoleReporter option to set it or turn it off.

Tyler Levine added 2 commits July 25, 2019 19:03
Allow overriding the console reporter
fb7164f
Add ways to silence console reporter output
b0dfa82 
Allows silencing the console reporter output by setting the reporter to 'none'
or by setting the quiet option.

Also adds the new consoleReporter option to the README
@tylerlevine tylerlevine force-pushed the allow-console-reporter-override branch from baae4e7 to b0dfa82 Compare July 26, 2019 02:06
@tylerlevine tylerlevine force-pushed the allow-console-reporter-override branch from 7f4a777 to 72a04f6 Compare July 26, 2019 02:23
RyanBellPOST
RyanBellPOST approved these changes Jul 29, 2019
View reviewed changes
Copy link

@RyanBellPOST RyanBellPOST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamgruber adamgruber merged commit 9222d7b into adamgruber:master Jul 29, 2019
@adamgruber
Copy link
Owner

@tylerlevine Thanks for your work on this. I'm going to try to get a release out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanBellPOST RyanBellPOST RyanBellPOST approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerlevine @adamgruber @RyanBellPOST