set expiry flag (FirebaseExtended#22)

adelinn · Sep 25, 2020 · b9edd24 · b9edd24
1 parent a17a591
commit b9edd24
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -86,9 +86,7 @@ build log.
 
 ### `expires` _{string}_
 
-> ⚠️ This option isn't supported yet. If you set it, it will be ignored. See [issue #7](https://github.com/FirebaseExtended/action-hosting-deploy/issues/7) for context.
-
-The length of time the channel should live. Default is 7 days.
+The length of time the channel should live. If left blank, uses the Firebase Hosting default expiry (7 days).
 
 ### `projectId` _{string}_
 

diff --git a/bin/action.min.js b/bin/action.min.js
diff --git a/src/deploy.ts b/src/deploy.ts
@@ -99,7 +99,11 @@ export async function deploy(gacFilename: string, deployConfig: DeployConfig) {
 
   const deploymentText = await execWithCredentials(
     "npx firebase-tools",
-    ["hosting:channel:deploy", channelId],
+    [
+      "hosting:channel:deploy",
+      channelId,
+      ...(expires ? ["--expires", expires] : []),
+    ],
     projectId,
     gacFilename
   );