Skip to content

Commit

Permalink
Make it possible to enable periodic compactions for BlobDB (facebook#…
Browse files Browse the repository at this point in the history
…6172)

Summary:
Periodic compactions ensure that even SSTs that do not get picked up
otherwise eventually go through compaction; used in conjunction with
BlobDB's garbage collection, they enable BlobDB to reclaim space when
old blob files are used by such straggling SSTs.
Pull Request resolved: facebook#6172

Test Plan: Ran `make check` and used the BlobDB mode of `db_bench`.

Differential Revision: D19045045

Pulled By: ltamasi

fbshipit-source-id: 04636ecc4b6cfe8d495bf656faa65d54a5eb1a93
  • Loading branch information
ltamasi authored and facebook-github-bot committed Dec 14, 2019
1 parent afa2420 commit 0d2172f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions utilities/blob_db/blob_db_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,6 @@ Status BlobDBImpl::Open(std::vector<ColumnFamilyHandle*>* handles) {
"Garbage collection cutoff must be in the interval [0.0, 1.0]");
}

// BlobDB does not support Periodic Compactions. So disable periodic
// compactions irrespective of the user set value.
cf_options_.periodic_compaction_seconds = 0;

// Temporarily disable compactions in the base DB during open; save the user
// defined value beforehand so we can restore it once BlobDB is initialized.
// Note: this is only needed if garbage collection is enabled.
Expand Down

0 comments on commit 0d2172f

Please sign in to comment.