Skip to content

Commit

Permalink
Merge pull request jmoiron#247 from v4n/master
Browse files Browse the repository at this point in the history
JSONText & GzippedText are safe in 1.7
  • Loading branch information
jmoiron authored Sep 14, 2016
2 parents 7451a4b + 74f9f64 commit f4291b0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ This breaks backwards compatibility, but it's in a way that is trivially fixable
(`s/JsonText/JSONText/g`). The `types` package is both experimental and not in
active development currently.

More importantly, [golang bug #13905](https://github.com/golang/go/issues/13905)
makes `types.JSONText` and `types.GzippedText` _potentially unsafe_, **especially**
when used with common auto-scan sqlx idioms like `Select` and `Get`.
* Using Go 1.6 and below with `types.JSONText` and `types.GzippedText` can be _potentially unsafe_, **especially** when used with common auto-scan sqlx idioms like `Select` and `Get`. See [golang bug #13905](https://github.com/golang/go/issues/13905).

### Backwards Compatibility

Expand Down

0 comments on commit f4291b0

Please sign in to comment.