Skip to content

Commit

Permalink
remove the call to ->write_super in __sync_filesystem
Browse files Browse the repository at this point in the history
Now that all filesystems provide ->sync_fs methods we can change
__sync_filesystem to only call ->sync_fs.

This gives us a clear separation between periodic writeouts which
are driven by ->write_super and data integrity syncs that go
through ->sync_fs. (modulo file_fsync which is also going away)

Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Christoph Hellwig authored and Al Viro committed Jun 12, 2009
1 parent d731e06 commit 0c95ee1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fs/sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ static int __sync_filesystem(struct super_block *sb, int wait)
else
sync_quota_sb(sb, -1);
sync_inodes_sb(sb, wait);
if (sb->s_dirt && sb->s_op->write_super)
sb->s_op->write_super(sb);
if (sb->s_op->sync_fs)
sb->s_op->sync_fs(sb, wait);
return __sync_blockdev(sb->s_bdev, wait);
Expand Down

0 comments on commit 0c95ee1

Please sign in to comment.