Make the privateKey a private field

adirc2023 · Nov 26, 2020 · 921a348 · 921a348
1 parent b87c860
commit 921a348
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/sdk/zksync.js/src/signer.ts b/sdk/zksync.js/src/signer.ts
@@ -15,14 +15,18 @@ import {
 import { Address, EthSignerType, PubKeyHash, Transfer, Withdraw, ForcedExit, ChangePubKey } from './types';
 
 export class Signer {
-    readonly privateKey: Uint8Array;
+    #privateKey: Uint8Array;
 
     private constructor(privKey: Uint8Array) {
-        this.privateKey = privKey;
+        this.#privateKey = privKey;
+    }
+
+    private privateKey(): Uint8Array {
+        return this.#privateKey;
     }
 
     async pubKeyHash(): Promise<PubKeyHash> {
-        return await privateKeyToPubKeyHash(this.privateKey);
+        return await privateKeyToPubKeyHash(this.privateKey());
     }
 
     transferSignBytes(transfer: {
@@ -57,7 +61,7 @@ export class Signer {
         nonce: number;
     }): Promise<Transfer> {
         const msgBytes = this.transferSignBytes(transfer);
-        const signature = await signTransactionBytes(this.privateKey, msgBytes);
+        const signature = await signTransactionBytes(this.privateKey(), msgBytes);
 
         return {
             type: 'Transfer',
@@ -113,7 +117,7 @@ export class Signer {
         nonce: number;
     }): Promise<Withdraw> {
         const msgBytes = this.withdrawSignBytes(withdraw);
-        const signature = await signTransactionBytes(this.privateKey, msgBytes);
+        const signature = await signTransactionBytes(this.privateKey(), msgBytes);
 
         return {
             type: 'Withdraw',
@@ -161,7 +165,7 @@ export class Signer {
         nonce: number;
     }): Promise<ForcedExit> {
         const msgBytes = this.forcedExitSignBytes(forcedExit);
-        const signature = await signTransactionBytes(this.privateKey, msgBytes);
+        const signature = await signTransactionBytes(this.privateKey(), msgBytes);
         return {
             type: 'ForcedExit',
             initiatorAccountId: forcedExit.initiatorAccountId,
@@ -210,7 +214,7 @@ export class Signer {
         nonce: number;
     }): Promise<ChangePubKey> {
         const msgBytes = this.changePubKeySignBytes(changePubKey);
-        const signature = await signTransactionBytes(this.privateKey, msgBytes);
+        const signature = await signTransactionBytes(this.privateKey(), msgBytes);
         return {
             type: 'ChangePubKey',
             accountId: changePubKey.accountId,