fix crash where listeners are not removed when app quits (firebase#2650)

adityadroid · Jul 2, 2020 · a2333ab · a2333ab
1 parent 1891854
commit a2333ab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/packages/cloud_firestore/cloud_firestore/CHANGELOG.md b/packages/cloud_firestore/cloud_firestore/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.13.7+1
+
+* Fix crash where listeners are not removed when app quits.
+
 ## 0.13.7
 
 * Clean up snapshot listeners when Android Activity is destroyed.

diff --git a/...ndroid/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java b/...ndroid/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java
@@ -489,6 +489,11 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
   }
 
   private void onDetachedFromEngine() {
+    observers.clear();
+    documentObservers.clear();
+    batches.clear();
+    transactions.clear();
+    completionTasks.clear();
     removeSnapshotListeners();
     channel.setMethodCallHandler(null);
     channel = null;

diff --git a/packages/cloud_firestore/cloud_firestore/pubspec.yaml b/packages/cloud_firestore/cloud_firestore/pubspec.yaml
@@ -3,7 +3,7 @@ description:
   Flutter plugin for Cloud Firestore, a cloud-hosted, noSQL database with
   live synchronization and offline support on Android and iOS.
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_firestore/cloud_firestore
-version: 0.13.7
+version: 0.13.7+1
 
 flutter:
   plugin: