ext4: fix special inode number checks in __ext4_iget()

The check for special (reserved) inode number checks in __ext4_iget() was broken by commit 8a36397: ("ext4: avoid declaring fs inconsistent due to invalid file handles"). This was caused by a botched reversal of the sense of the flag now known as EXT4_IGET_SPECIAL (when it was previously named EXT4_IGET_NORMAL). Fix the logic appropriately. Fixes: 8a36397 ("ext4: avoid declaring fs inconsistent...") Signed-off-by: Theodore Ts'o <[email protected]> Reported-by: Dan Carpenter <[email protected]> Cc: [email protected]
adn770 · Jan 1, 2019 · 191ce17 · 191ce17
1 parent 95cb671
commit 191ce17
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
@@ -4834,7 +4834,7 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
 	gid_t i_gid;
 	projid_t i_projid;
 
-	if (((flags & EXT4_IGET_NORMAL) &&
+	if ((!(flags & EXT4_IGET_SPECIAL) &&
 	     (ino < EXT4_FIRST_INO(sb) && ino != EXT4_ROOT_INO)) ||
 	    (ino < EXT4_ROOT_INO) ||
 	    (ino > le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count))) {