Skip to content

Commit

Permalink
crypto: hisilicon - select CRYPTO_LIB_DES while compiling SEC driver
Browse files Browse the repository at this point in the history
When CRYPTO_DEV_HISI_SEC=y, below compilation error is found after
'commit 894b68d ("crypto: hisilicon/des - switch to new verification routines")':

drivers/crypto/hisilicon/sec/sec_algs.o: In function `sec_alg_skcipher_setkey_des_cbc':
sec_algs.c:(.text+0x11f0): undefined reference to `des_expand_key'
drivers/crypto/hisilicon/sec/sec_algs.o: In function `sec_alg_skcipher_setkey_des_ecb':
sec_algs.c:(.text+0x1390): undefined reference to `des_expand_key'
make: *** [vmlinux] Error 1

This because DES library has been moved to lib/crypto in this commit
'04007b0e6cbb ("crypto: des - split off DES library from generic DES cipher driver")'.
Fix this by selecting CRYPTO_LIB_DES in CRYPTO_DEV_HISI_SEC.

Fixes: 04007b0 ("crypto: des - split off DES library from generic DES cipher driver")
Fixes: 894b68d ("crypto: hisilicon/des - switch to new verification routines")

Signed-off-by: Mao Wenan <[email protected]>
Acked-by: Jonathan Cameron <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
Mao Wenan authored and herbertx committed Aug 30, 2019
1 parent 9ecf5ad commit 1bbbbcf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/crypto/hisilicon/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ config CRYPTO_DEV_HISI_SEC
tristate "Support for Hisilicon SEC crypto block cipher accelerator"
select CRYPTO_BLKCIPHER
select CRYPTO_ALGAPI
select CRYPTO_LIB_DES
select SG_SPLIT
depends on ARM64 || COMPILE_TEST
depends on HAS_IOMEM
Expand Down

0 comments on commit 1bbbbcf

Please sign in to comment.