Skip to content

Commit

Permalink
ALSA: usb: Remove superfluous snd_pcm_suspend*() calls
Browse files Browse the repository at this point in the history
The call of snd_pcm_suspend_all() & co became superfluous since we
call it in the PCM PM ops.  Let's remove them.

Reviewed-by: Jaroslav Kysela <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
tiwai committed Jan 15, 2019
1 parent 17bc481 commit 2c76706
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion sound/usb/card.c
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,6 @@ static int usb_audio_suspend(struct usb_interface *intf, pm_message_t message)
snd_power_change_state(chip->card, SNDRV_CTL_POWER_D3hot);
if (!chip->num_suspended_intf++) {
list_for_each_entry(as, &chip->pcm_list, list) {
snd_pcm_suspend_all(as->pcm);
snd_usb_pcm_suspend(as);
as->substream[0].need_setup_ep =
as->substream[1].need_setup_ep = true;
Expand Down
4 changes: 1 addition & 3 deletions sound/usb/line6/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -849,10 +849,8 @@ int line6_suspend(struct usb_interface *interface, pm_message_t message)
if (line6->properties->capabilities & LINE6_CAP_CONTROL)
line6_stop_listen(line6);

if (line6pcm != NULL) {
snd_pcm_suspend_all(line6pcm->pcm);
if (line6pcm != NULL)
line6pcm->flags = 0;
}

return 0;
}
Expand Down

0 comments on commit 2c76706

Please sign in to comment.