Skip to content

Commit

Permalink
KVM: cleanup kvm trace
Browse files Browse the repository at this point in the history
This patch does:

 - no need call tracepoint_synchronize_unregister() when kvm module
   is unloaded since ftrace can handle it

 - cleanup ftrace's macro

Signed-off-by: Xiao Guangrong <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
  • Loading branch information
Xiao Guangrong authored and avikivity committed May 17, 2010
1 parent 06056bf commit 2ed152a
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 8 deletions.
1 change: 0 additions & 1 deletion arch/x86/kvm/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ module_param(oos_shadow, bool, 0644);

#include <trace/events/kvm.h>

#undef TRACE_INCLUDE_FILE
#define CREATE_TRACE_POINTS
#include "mmutrace.h"

Expand Down
7 changes: 5 additions & 2 deletions arch/x86/kvm/mmutrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

#undef TRACE_SYSTEM
#define TRACE_SYSTEM kvmmmu
#define TRACE_INCLUDE_PATH .
#define TRACE_INCLUDE_FILE mmutrace

#define KVM_MMU_PAGE_FIELDS \
__field(__u64, gfn) \
Expand Down Expand Up @@ -216,5 +214,10 @@ TRACE_EVENT(

#endif /* _TRACE_KVMMMU_H */

#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH .
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE mmutrace

/* This part must be outside protection */
#include <trace/define_trace.h>
7 changes: 5 additions & 2 deletions arch/x86/kvm/trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

#undef TRACE_SYSTEM
#define TRACE_SYSTEM kvm
#define TRACE_INCLUDE_PATH arch/x86/kvm
#define TRACE_INCLUDE_FILE trace

/*
* Tracepoint for guest mode entry.
Expand Down Expand Up @@ -575,5 +573,10 @@ TRACE_EVENT(kvm_skinit,

#endif /* _TRACE_KVM_H */

#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH arch/x86/kvm
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE trace

/* This part must be outside protection */
#include <trace/define_trace.h>
2 changes: 1 addition & 1 deletion arch/x86/kvm/x86.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include <linux/srcu.h>
#include <linux/slab.h>
#include <trace/events/kvm.h>
#undef TRACE_INCLUDE_FILE

#define CREATE_TRACE_POINTS
#include "trace.h"

Expand Down
1 change: 0 additions & 1 deletion include/trace/events/kvm.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#undef TRACE_SYSTEM
#define TRACE_SYSTEM kvm
#define TRACE_INCLUDE_FILE kvm

#if defined(__KVM_HAVE_IOAPIC)
TRACE_EVENT(kvm_set_irq,
Expand Down
1 change: 0 additions & 1 deletion virt/kvm/kvm_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2279,7 +2279,6 @@ EXPORT_SYMBOL_GPL(kvm_init);

void kvm_exit(void)
{
tracepoint_synchronize_unregister();
kvm_exit_debug();
misc_deregister(&kvm_dev);
kmem_cache_destroy(kvm_vcpu_cache);
Expand Down

0 comments on commit 2ed152a

Please sign in to comment.