Skip to content

Commit

Permalink
ARM: OMAP2+: add missing of_node_put after of_device_is_available
Browse files Browse the repository at this point in the history
Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: e0c827a ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
  • Loading branch information
JuliaLawall authored and tmlind committed Mar 22, 2019
1 parent 3e2cf62 commit 3064530
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion arch/arm/mach-omap2/display.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,10 @@ static int __init omapdss_init_of(void)
if (!node)
return 0;

if (!of_device_is_available(node))
if (!of_device_is_available(node)) {
of_node_put(node);
return 0;
}

pdev = of_find_device_by_node(node);

Expand Down

0 comments on commit 3064530

Please sign in to comment.