Skip to content

Commit

Permalink
hugetlbfs: use pagevec_lookup_range() in remove_inode_hugepages()
Browse files Browse the repository at this point in the history
We want only pages from given range in remove_inode_hugepages().  Use
pagevec_lookup_range() instead of pagevec_lookup().

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Jan Kara <[email protected]>
Reviewed-by: Mike Kravetz <[email protected]>
Cc: Nadia Yvette Chambers <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
jankara authored and torvalds committed Sep 7, 2017
1 parent 2b85a61 commit 48f2301
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions fs/hugetlbfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -403,39 +403,25 @@ static void remove_inode_hugepages(struct inode *inode, loff_t lstart,
struct pagevec pvec;
pgoff_t next, index;
int i, freed = 0;
long lookup_nr = PAGEVEC_SIZE;
bool truncate_op = (lend == LLONG_MAX);

memset(&pseudo_vma, 0, sizeof(struct vm_area_struct));
pseudo_vma.vm_flags = (VM_HUGETLB | VM_MAYSHARE | VM_SHARED);
pagevec_init(&pvec, 0);
next = start;
while (next < end) {
/*
* Don't grab more pages than the number left in the range.
*/
if (end - next < lookup_nr)
lookup_nr = end - next;

/*
* When no more pages are found, we are done.
*/
if (!pagevec_lookup(&pvec, mapping, &next, lookup_nr))
if (!pagevec_lookup_range(&pvec, mapping, &next, end - 1,
PAGEVEC_SIZE))
break;

for (i = 0; i < pagevec_count(&pvec); ++i) {
struct page *page = pvec.pages[i];
u32 hash;

/*
* The page (index) could be beyond end. This is
* only possible in the punch hole case as end is
* max page offset in the truncate case.
*/
index = page->index;
if (index >= end)
break;

hash = hugetlb_fault_mutex_hash(h, current->mm,
&pseudo_vma,
mapping, index, 0);
Expand Down

0 comments on commit 48f2301

Please sign in to comment.