Smack: Safer check for a socket in file_receive

The check of S_ISSOCK() in smack_file_receive() is not appropriate if the passed descriptor is a socket. Reported-by: Stephen Smalley <[email protected]> Signed-off-by: Casey Schaufler <[email protected]>
adn770 · Jun 1, 2017 · 51d59af · 51d59af
1 parent e661a58
commit 51d59af
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
@@ -1915,7 +1915,7 @@ static int smack_file_receive(struct file *file)
 	smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);
 	smk_ad_setfield_u_fs_path(&ad, file->f_path);
 
-	if (S_ISSOCK(inode->i_mode)) {
+	if (inode->i_sb->s_magic == SOCKFS_MAGIC) {
 		sock = SOCKET_I(inode);
 		ssp = sock->sk->sk_security;
 		tsp = current_security();