ocfs2: Fix bogus error message from ocfs2_global_read_info

'status' variable in ocfs2_global_read_info() is always != 0 when leaving the function because it happens to contain number of read bytes. Thus we always log error message although everything is OK. Since all error cases properly call mlog_errno() before jumping to out_err, there's no reason to call mlog_errno() on exit at all. This is a fallout of c1e8d35 (conversion of mlog_exit() calls). Signed-off-by: Jan Kara <[email protected]> Signed-off-by: Joel Becker <[email protected]>
adn770 · Jul 4, 2012 · a4564ea · a4564ea
1 parent 65622e6
commit a4564ea
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c
@@ -399,8 +399,6 @@ int ocfs2_global_read_info(struct super_block *sb, int type)
 			      msecs_to_jiffies(oinfo->dqi_syncms));
 
 out_err:
-	if (status)
-		mlog_errno(status);
 	return status;
 out_unlock:
 	ocfs2_unlock_global_qf(oinfo, 0);