Skip to content

Commit

Permalink
9p: fix flags length in net
Browse files Browse the repository at this point in the history
Some files in the net/9p directory uses "int" for flags. This can
cause hard to find bugs on some architectures. This patch converts the
flags to use "long" instead.

This bug was discovered by doing an allyesconfig make on the -rt kernel
where checks are done to ensure all flags are of size sizeof(long).

Signed-off-by: Steven Rostedt <[email protected]>
Acked-by: Eric Van Hensbergen <[email protected]>
  • Loading branch information
rostedt authored and Eric Van Hensbergen committed May 15, 2008
1 parent 728fc4e commit d0c4471
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion net/9p/trans_virtio.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ static void p9_virtio_close(struct p9_trans *trans)
{
struct virtio_chan *chan = trans->priv;
int count;
unsigned int flags;
unsigned long flags;

spin_lock_irqsave(&chan->lock, flags);
p9_idpool_destroy(chan->tagpool);
Expand Down
4 changes: 2 additions & 2 deletions net/9p/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ int p9_idpool_get(struct p9_idpool *p)
{
int i = 0;
int error;
unsigned int flags;
unsigned long flags;

retry:
if (idr_pre_get(&p->pool, GFP_KERNEL) == 0)
Expand Down Expand Up @@ -120,7 +120,7 @@ EXPORT_SYMBOL(p9_idpool_get);

void p9_idpool_put(int id, struct p9_idpool *p)
{
unsigned int flags;
unsigned long flags;
spin_lock_irqsave(&p->lock, flags);
idr_remove(&p->pool, id);
spin_unlock_irqrestore(&p->lock, flags);
Expand Down

0 comments on commit d0c4471

Please sign in to comment.