Skip to content

Commit

Permalink
usb: renesas_usbhs: add R-Car Gen3 power control
Browse files Browse the repository at this point in the history
Since the usb2 phy driver for gen3 (phy-rcar-gen3-usb2) cannot access
LPSTS and UGCTRL2 registers in the HSUSB module, this driver have to
initialize the registers. So, this patch adds such handling code into
rcar3.c.

Signed-off-by: Yoshihiro Shimoda <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
  • Loading branch information
shimoday authored and felipebalbi committed Mar 4, 2016
1 parent 7580862 commit de18757
Show file tree
Hide file tree
Showing 5 changed files with 69 additions and 5 deletions.
2 changes: 1 addition & 1 deletion drivers/usb/renesas_usbhs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs.o

renesas_usbhs-y := common.o mod.o pipe.o fifo.o rcar2.o
renesas_usbhs-y := common.o mod.o pipe.o fifo.o rcar2.o rcar3.o

ifneq ($(CONFIG_USB_RENESAS_USBHS_HCD),)
renesas_usbhs-y += mod_host.o
Expand Down
14 changes: 10 additions & 4 deletions drivers/usb/renesas_usbhs/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <linux/sysfs.h>
#include "common.h"
#include "rcar2.h"
#include "rcar3.h"

/*
* image of renesas_usbhs
Expand Down Expand Up @@ -477,18 +478,16 @@ static const struct of_device_id usbhs_of_match[] = {
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
{
/* Gen3 is compatible with Gen2 */
.compatible = "renesas,usbhs-r8a7795",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
.data = (void *)USBHS_TYPE_RCAR_GEN3,
},
{
.compatible = "renesas,rcar-gen2-usbhs",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
{
/* Gen3 is compatible with Gen2 */
.compatible = "renesas,rcar-gen3-usbhs",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
.data = (void *)USBHS_TYPE_RCAR_GEN3,
},
{ },
};
Expand Down Expand Up @@ -578,6 +577,13 @@ static int usbhs_probe(struct platform_device *pdev)
priv->dparam.pipe_size = ARRAY_SIZE(usbhsc_new_pipe);
}
break;
case USBHS_TYPE_RCAR_GEN3:
priv->pfunc = usbhs_rcar3_ops;
if (!priv->dparam.pipe_configs) {
priv->dparam.pipe_configs = usbhsc_new_pipe;
priv->dparam.pipe_size = ARRAY_SIZE(usbhsc_new_pipe);
}
break;
default:
if (!info->platform_callback.get_id) {
dev_err(&pdev->dev, "no platform callbacks");
Expand Down
54 changes: 54 additions & 0 deletions drivers/usb/renesas_usbhs/rcar3.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/*
* Renesas USB driver R-Car Gen. 3 initialization and power control
*
* Copyright (C) 2016 Renesas Electronics Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*
*/

#include <linux/io.h>
#include "common.h"
#include "rcar3.h"

#define LPSTS 0x102
#define UGCTRL2 0x184 /* 32-bit register */

/* Low Power Status register (LPSTS) */
#define LPSTS_SUSPM 0x4000

/* USB General control register 2 (UGCTRL2), bit[31:6] should be 0 */
#define UGCTRL2_RESERVED_3 0x00000001 /* bit[3:0] should be B'0001 */
#define UGCTRL2_USB0SEL_OTG 0x00000030

void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
{
iowrite32(data, priv->base + reg);
}

static int usbhs_rcar3_power_ctrl(struct platform_device *pdev,
void __iomem *base, int enable)
{
struct usbhs_priv *priv = usbhs_pdev_to_priv(pdev);

usbhs_write32(priv, UGCTRL2, UGCTRL2_RESERVED_3 | UGCTRL2_USB0SEL_OTG);

if (enable)
usbhs_bset(priv, LPSTS, LPSTS_SUSPM, LPSTS_SUSPM);
else
usbhs_bset(priv, LPSTS, LPSTS_SUSPM, 0);

return 0;
}

static int usbhs_rcar3_get_id(struct platform_device *pdev)
{
return USBHS_GADGET;
}

const struct renesas_usbhs_platform_callback usbhs_rcar3_ops = {
.power_ctrl = usbhs_rcar3_power_ctrl,
.get_id = usbhs_rcar3_get_id,
};
3 changes: 3 additions & 0 deletions drivers/usb/renesas_usbhs/rcar3.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#include "common.h"

extern const struct renesas_usbhs_platform_callback usbhs_rcar3_ops;
1 change: 1 addition & 0 deletions include/linux/usb/renesas_usbhs.h
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ struct renesas_usbhs_driver_param {
};

#define USBHS_TYPE_RCAR_GEN2 1
#define USBHS_TYPE_RCAR_GEN3 2

/*
* option:
Expand Down

0 comments on commit de18757

Please sign in to comment.