iio: accel: mma9551: Check gpiod_to_irq return value

The return value of gpiod_to_irq should be checked before giving it to devm_request_threaded_irq in order to not pass an error code in case it fails. Signed-off-by: Roberta Dobrescu <[email protected]> Reviewed-by: Vlad Dogaru <[email protected]> Acked-by: Uwe Kleine-König <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
adn770 · Mar 9, 2015 · debf6d8 · debf6d8
1 parent 4a428bf
commit debf6d8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c
@@ -425,7 +425,11 @@ static int mma9551_gpio_probe(struct iio_dev *indio_dev)
 			return PTR_ERR(gpio);
 		}
 
-		data->irqs[i] = gpiod_to_irq(gpio);
+		ret = gpiod_to_irq(gpio);
+		if (ret < 0)
+			return ret;
+
+		data->irqs[i] = ret;
 		ret = devm_request_threaded_irq(dev, data->irqs[i],
 				NULL, mma9551_event_handler,
 				IRQF_TRIGGER_RISING | IRQF_ONESHOT,