Skip to content

Commit

Permalink
net/sched: remove unused functions for matchall offload
Browse files Browse the repository at this point in the history
Cleanup unused functions and variables after porting to the newer
intermediate representation.

Signed-off-by: Pieter Jansen van Vuuren <[email protected]>
Reviewed-by: Jakub Kicinski <[email protected]>
Acked-by: Jiri Pirko <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
pjvuuren authored and davem330 committed May 6, 2019
1 parent 9681e8b commit dfcb19f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 27 deletions.
25 changes: 0 additions & 25 deletions include/net/pkt_cls.h
Original file line number Diff line number Diff line change
Expand Up @@ -371,30 +371,6 @@ static inline bool tcf_exts_has_actions(struct tcf_exts *exts)
#endif
}

/**
* tcf_exts_has_one_action - check if exactly one action is present
* @exts: tc filter extensions handle
*
* Returns true if exactly one action is present.
*/
static inline bool tcf_exts_has_one_action(struct tcf_exts *exts)
{
#ifdef CONFIG_NET_CLS_ACT
return exts->nr_actions == 1;
#else
return false;
#endif
}

static inline struct tc_action *tcf_exts_first_action(struct tcf_exts *exts)
{
#ifdef CONFIG_NET_CLS_ACT
return exts->actions[0];
#else
return NULL;
#endif
}

/**
* tcf_exts_exec - execute tc filter extensions
* @skb: socket buffer
Expand Down Expand Up @@ -790,7 +766,6 @@ struct tc_cls_matchall_offload {
struct tc_cls_common_offload common;
enum tc_matchall_command command;
struct flow_rule *rule;
struct tcf_exts *exts;
unsigned long cookie;
};

Expand Down
2 changes: 0 additions & 2 deletions net/sched/cls_matchall.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ static int mall_replace_hw_filter(struct tcf_proto *tp,

tc_cls_common_offload_init(&cls_mall.common, tp, head->flags, extack);
cls_mall.command = TC_CLSMATCHALL_REPLACE;
cls_mall.exts = &head->exts;
cls_mall.cookie = cookie;

err = tc_setup_flow_action(&cls_mall.rule->action, &head->exts);
Expand Down Expand Up @@ -297,7 +296,6 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, tc_setup_cb_t *cb,
tc_cls_common_offload_init(&cls_mall.common, tp, head->flags, extack);
cls_mall.command = add ?
TC_CLSMATCHALL_REPLACE : TC_CLSMATCHALL_DESTROY;
cls_mall.exts = &head->exts;
cls_mall.cookie = (unsigned long)head;

err = tc_setup_flow_action(&cls_mall.rule->action, &head->exts);
Expand Down

0 comments on commit dfcb19f

Please sign in to comment.