Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aria-expanded from panel to top level link #62

Closed
wants to merge 2 commits into from

Conversation

maedi
Copy link
Contributor

@maedi maedi commented Jan 20, 2020

aria-expanded should be on the element that expands the dropdown, not the dropdown itself. The attribute is currently on the sub panel div but it needs to be on the a[role="button"] above it.

This recommendation was brought to us by an accessibility consultant and is confirmed in the "Simple dropdown" example on this site: https://www.accessibility-developer-guide.com/examples/widgets/dropdown/

HTML before:

<a role="button"></a>
<div class="sub-nav" aria-expanded="true"></div>

HTML after:

<a role="button" aria-expanded="true"></a>
<div class="panel"></div>

@maedi maedi requested a review from majornista January 20, 2020 23:33
@maedi maedi mentioned this pull request Jan 24, 2020
@maedi
Copy link
Contributor Author

maedi commented Dec 9, 2020

Merged via pull request #66.

@maedi maedi closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant