Fix mistargeting of topnav link when no panel #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a megamenu doesn't have a sub panel, the current selectors get confused. The selector for
topnavitempanelwill select the top level link instead and add its sub panel classes to it. This pull request more specifically targets top level link and its panel.While the megamenu still works when panel attributes are added top level link, it breaks VoiceOver on iOS. In mobile when using VoiceOver and you expand the megamenu by toggling the menu button, you will then be unable to swipe to the navigation links. "Swipe" in this context refers to a touch gesture that tabs to the next item. This is because those sub panel attributes make the top level link invisible to VoiceOver (aria-hidden="true", "aria-expanded="false", role="region").