Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions reusable workflows #134

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

timkimadobe
Copy link
Collaborator

@timkimadobe timkimadobe commented Nov 21, 2024

Description

This PR migrates the Edge Identity iOS repo to use the reusable workflows from aepsdk-commons for:

  • Update versions
    • Removal of local version scripts
  • Release
  • Build and test
    • Makefile updates for matrix compatibility and default derived data location logic
    • Splitting test rules into unit and functional for parallelization

Dependency chanages

Testing changes

  • Update AEPTestUtils to 5.2.2 (Core)
    • Update deprecated usage of EventHub.reset to MobileCore.resetSDK

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (d65794f) to head (85c336f).
Report is 44 commits behind head on dev.

❗ There is a different number of reports uploaded between BASE (d65794f) and HEAD (85c336f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d65794f) HEAD (85c336f)
1 0
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #134       +/-   ##
===========================================
- Coverage   97.28%   81.64%   -15.64%     
===========================================
  Files           8        8               
  Lines         368      986      +618     
===========================================
+ Hits          358      805      +447     
- Misses         10      181      +171     

version: ${{ github.event.inputs.version }}
branch: ${{ github.event.inputs.branch }}
dependencies: AEPCore ${{ github.event.inputs.core-dependency }}
paths: Package.swift:swift_spm, AEPEdge.podspec, AEPEdge.xcodeproj/project.pbxproj, Sources/IdentityConstants.swift
Copy link
Collaborator

@addb addb Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating to AEPEdgeIdentity
AEPEdgeIdentity.podspec
AEPEdgeIdentity.xcodeproj/project.pbxproj

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated

Makefile Show resolved Hide resolved
@timkimadobe timkimadobe requested review from cacheung and addb December 5, 2024 00:40
@timkimadobe timkimadobe merged commit 52429c6 into adobe:dev Dec 5, 2024
15 of 17 checks passed
@timkimadobe timkimadobe deleted the workflow-updates branch December 5, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants