Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated token definitions #5062

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Feb 4, 2025

Description

This PR related to the breaking internal change from pre, post or foundations tags of @spectrum-css where it is flattened to use semver versioning.

Related issue(s)

  • N/A

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc requested a review from a team as a code owner February 4, 2025 08:40
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: e1ff7dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Feb 4, 2025

Tachometer results

Currently, no packages are changed by this PR...

Copy link

github-actions bot commented Feb 4, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.98 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.953 kB 236.291 kB 218.182 kB 🏆
Scripts 61.823 kB 54.327 kB 54.139 kB 🏆
Stylesheet 53.069 kB 47.443 kB 29.595 kB 🏆
Document 6.221 kB 5.462 kB 🏆 5.466 kB
Font 126.845 kB 126.606 kB 🏆 126.633 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13132760161

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 98.158%

Files with Coverage Reduction New Missed Lines %
packages/dialog/src/DialogBase.ts 5 91.53%
packages/tray/src/Tray.ts 11 88.02%
Totals Coverage Status
Change from base Build 13130469425: -0.03%
Covered Lines: 33085
Relevant Lines: 33528

💛 - Coveralls

@castastrophe castastrophe force-pushed the tokens/semver-from-foundation branch from 81570ec to fb62c81 Compare February 4, 2025 20:27
@adobe adobe deleted a comment from github-actions bot Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants