Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(picker): update css version to latest foundations #5087

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Feb 11, 2025

Description

Bumping the "Picker" component to the latest CSS version, to get up to date with the latest Spectrum 2 designs.

Related issue(s)

Motivation and context

After the recent release of Spectrum 2 (foundations), we want to keep updating our components to the latest design specs.

How has this been tested?

All changes manually validated against the CSS implementation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 3725140

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

Copy link

github-actions bot commented Feb 12, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.791 kB 235.243 kB 234.562 kB 🏆
Scripts 61.569 kB 54.366 kB 54.273 kB 🏆
Stylesheet 53.166 kB 46.338 kB 45.732 kB 🏆
Document 6.222 kB 5.503 kB 5.49 kB 🏆
Font 126.97 kB 126.624 kB 126.615 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@rubencarvalho rubencarvalho marked this pull request as ready for review February 12, 2025 14:06
@rubencarvalho rubencarvalho requested a review from a team as a code owner February 12, 2025 14:06
@rubencarvalho rubencarvalho force-pushed the ruben/bump-picker-css branch 2 times, most recently from 846d603 to 173da8e Compare February 12, 2025 14:15
@Rajdeepc Rajdeepc merged commit 7f3e0f9 into main Feb 12, 2025
25 checks passed
@Rajdeepc Rajdeepc deleted the ruben/bump-picker-css branch February 12, 2025 15:52
@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13287783943

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.192%

Totals Coverage Status
Change from base Build 13263165624: 0.003%
Covered Lines: 33099
Relevant Lines: 33528

💛 - Coveralls

TarunAdobe pushed a commit that referenced this pull request Feb 14, 2025
* chore(picker): update css version to latest foundations

* chore: update golden images cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants