-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-162519: Nav List - Link to external page #3482
MWPW-162519: Nav List - Link to external page #3482
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3482 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 256 256
Lines 60094 60133 +39
=======================================
+ Hits 57982 58021 +39
Misses 2112 2112 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
a3d5dfb
to
3b7510c
Compare
5eb4e8e
to
0041e55
Compare
Reminder to set the |
Skipped 3482: "MWPW-162519: Nav List - Link to external page" due to file "libs/blocks/tabs/tabs.js" overlap. Merging will be attempted in the next batch |
Updated Milo tabs to support linking to separate pages as was previously supported in the Dexter Navigation List component.
Authoring:
section-metadata
of each tab should have thelink
field. The value should be a relative path to the page related to that tab:The
tab
parameter in the URL works as before:If specified, it determines which tab is selected. The tab parameter takes precedence. For example, if you navigate to the page associated with tab 1 but include the tab parameter to select tab 2, tab 2 will be selected, and the page will update to reflect the content associated with tab 2.
See example: https://mwpw-162519-tabs-with-links--milo--mirafedas.hlx.live/drafts/mirafedas/tabs/tabs-page-2?tab=demo-2&martech=off
Here is a test page showcasing the use case of nested tabs:
https://mwpw-162519-tabs-with-links--milo--mirafedas.hlx.live/drafts/mirafedas/tabs/tabs-in-tabs-3&martech=off
Here is a test page showcasing the use case of nested tabs together with the
tab
parameter:https://mwpw-162519-tabs-with-links--milo--mirafedas.hlx.live/drafts/mirafedas/tabs/tabs-in-tabs-3?tab=acrobat-3&martech=off
If the
link
property is not provided, tabs will have their default behavior.Resolves: MWPW-162519
Test URLs: