Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162519: Nav List - Link to external page #3482

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mirafedas
Copy link
Contributor

@mirafedas mirafedas commented Jan 14, 2025

Updated Milo tabs to support linking to separate pages as was previously supported in the Dexter Navigation List component.

Authoring:

  1. A separate page should be created for each tab;
  2. On each page the section-metadata of each tab should have the link field. The value should be a relative path to the page related to that tab:
    Screenshot 2025-01-13 at 15 01 10

The tab parameter in the URL works as before:
If specified, it determines which tab is selected. The tab parameter takes precedence. For example, if you navigate to the page associated with tab 1 but include the tab parameter to select tab 2, tab 2 will be selected, and the page will update to reflect the content associated with tab 2.
See example: https://mwpw-162519-tabs-with-links--milo--mirafedas.hlx.live/drafts/mirafedas/tabs/tabs-page-2?tab=demo-2&martech=off

Here is a test page showcasing the use case of nested tabs:
https://mwpw-162519-tabs-with-links--milo--mirafedas.hlx.live/drafts/mirafedas/tabs/tabs-in-tabs-3&martech=off

Here is a test page showcasing the use case of nested tabs together with the tab parameter:
https://mwpw-162519-tabs-with-links--milo--mirafedas.hlx.live/drafts/mirafedas/tabs/tabs-in-tabs-3?tab=acrobat-3&martech=off

If the link property is not provided, tabs will have their default behavior.

Resolves: MWPW-162519

Test URLs:

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (62d554b) to head (0041e55).
Report is 32 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3482   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         256      256           
  Lines       60094    60133   +39     
=======================================
+ Hits        57982    58021   +39     
  Misses       2112     2112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@mirafedas mirafedas force-pushed the mwpw-162519-tabs-with-links branch from a3d5dfb to 3b7510c Compare January 15, 2025 16:19
@mirafedas mirafedas force-pushed the mwpw-162519-tabs-with-links branch from 5eb4e8e to 0041e55 Compare January 16, 2025 11:35
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 22, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 23, 2025

Skipped 3482: "MWPW-162519: Nav List - Link to external page" due to file "libs/blocks/tabs/tabs.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 2e837de into adobecom:stage Jan 27, 2025
24 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants