MWPW-166002 | [MEP] Use Target served version of manifest in prod when Target experience is chosen #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepstage #3527 +/- ##
=========================================
Coverage 96.47% 96.47%
=========================================
Files 260 260
Lines 60582 60588 +6
=========================================
+ Hits 58444 58450 +6
Misses 2138 2138 ☔ View full report in Codecov by Sentry. |
markpadbe
approved these changes
Jan 22, 2025
denlight
force-pushed
the
manifest-server-vs-target
branch
from
996b7f6 to
39afdf3
Compare
vgoodric
approved these changes
Jan 24, 2025
ivanvatadobe
approved these changes
Jan 24, 2025
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
* MWPW-166355 [MEP] Number and symbols are very small in MEP button on RTL pages (#3541) update font family * MWPW-166002 | [MEP] Use Target served version of manifest in prod when Target experience is chosen (#3527) * Added server vs target manifest handling * refactored a bit * refactored test --------- Co-authored-by: Denys Fedotov <[email protected]> * MWPW-159369 [cc][LANA] Error reported: target response time: 0.5 (#3475) * add sample rate * change error type * MWPW-156867 [MILO][MEP][ANALYTICS] Support Column nicknames (#3510) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * create mepxlg branch * update library * require full hostname match * update reference for unit test * update unit tests * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * add federated link function to registerInBlockActions * add to unit test * initial commit * stash commit * remove dupe valMap const * update test files * linting error fix --------- Co-authored-by: vgoodric <[email protected]> * MWPW-166639 [MEP] Removing OST links doesn't work when MEP button is on (#3556) exclude ost links from highlight --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Jan Ivan Viloria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-166002
Test URLs:
QA Links:
For all After links the expected text header has been provided.
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?audience=edu&env=prod
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?audience=edu
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?env=prod
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?audience=edu&env=prod&milolibs=manifest-server-vs-target - Title Saved in Target
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?audience=edu&milolibs=manifest-server-vs-target - Preview Target Title
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?env=prod&milolibs=manifest-server-vs-target - Updated GWP Title
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2025/q1/manifest-server-vs-target/page?milolibs=manifest-server-vs-target - Updated GWP Title